diff options
| author | Dmitry Vyukov <dvyukov@google.com> | 2026-01-02 15:15:21 +0100 |
|---|---|---|
| committer | Dmitry Vyukov <dvyukov@google.com> | 2026-01-02 15:27:58 +0000 |
| commit | 5cdbe12ef7ec1ee2d99c5430924aab23c0fea503 (patch) | |
| tree | 58f2b79f952a7feaa507eb015eab4a1eb253ab70 /vm | |
| parent | a10c0112aec1525f7ca5f74716fc5f0552e2d05e (diff) | |
all: remove unused nolint directives
Diffstat (limited to 'vm')
| -rw-r--r-- | vm/proxyapp/proxyappclient.go | 2 | ||||
| -rw-r--r-- | vm/proxyapp/proxyappclient_test.go | 12 | ||||
| -rw-r--r-- | vm/vm_test.go | 1 |
3 files changed, 2 insertions, 13 deletions
diff --git a/vm/proxyapp/proxyappclient.go b/vm/proxyapp/proxyappclient.go index c3740ce6a..ffc5d5b85 100644 --- a/vm/proxyapp/proxyappclient.go +++ b/vm/proxyapp/proxyappclient.go @@ -423,7 +423,6 @@ type instance struct { } // Copy copies a hostSrc file into VM and returns file name in VM. -// nolint: dupl func (inst *instance) Copy(hostSrc string) (string, error) { var reply proxyrpc.CopyResult params := proxyrpc.CopyParams{ @@ -450,7 +449,6 @@ func (inst *instance) Copy(hostSrc string) (string, error) { // Forward sets up forwarding from within VM to the given tcp // port on the host and returns the address to use in VM. -// nolint: dupl func (inst *instance) Forward(port int) (string, error) { var reply proxyrpc.ForwardResult err := inst.ProxyApp.Call( diff --git a/vm/proxyapp/proxyappclient_test.go b/vm/proxyapp/proxyappclient_test.go index 1bf7d0571..8d9d9f91c 100644 --- a/vm/proxyapp/proxyappclient_test.go +++ b/vm/proxyapp/proxyappclient_test.go @@ -137,10 +137,7 @@ func TestCtor_FailedStartProxyApp(t *testing.T) { assert.Nil(t, p) } -// TODO: reuse proxyAppServerFixture() code: func could be called here once Mock.Unset() error -// -// fixed https://github.com/stretchr/testify/issues/1236 -// nolint: dupl +// TODO: reuse proxyAppServerFixture() code: func could be called here once Mock.Unset() error. func TestCtor_FailedConstructPool(t *testing.T) { mProxyAppServer, stdin, stdout, stderr := makeMockProxyAppProcess(t) @@ -198,9 +195,7 @@ func initProxyAppServerFixture(mProxyAppServer *mockProxyAppInterface) *mockProx return mProxyAppServer } -// TODO: to remove duplicate see TestCtor_FailedConstructPool() comment -// -// nolint: dupl +// TODO: to remove duplicate see TestCtor_FailedConstructPool() comment. func proxyAppServerFixture(t *testing.T) (*mockProxyAppInterface, *mockCommandRunner, *proxyAppParams) { mProxyAppServer, stdin, stdout, stderr := makeMockProxyAppProcess(t) @@ -361,7 +356,6 @@ func TestInstance_Copy_OK(t *testing.T) { assert.NotEmpty(t, remotePath) } -// nolint: dupl func TestInstance_Copy_Failure(t *testing.T) { mockInstance, inst := createInstanceFixture(t) mockInstance. @@ -390,7 +384,6 @@ func TestInstance_Forward_OK(t *testing.T) { assert.Equal(t, "manager_address:12345", remoteAddressToUse) } -// nolint: dupl func TestInstance_Forward_Failure(t *testing.T) { mockInstance, inst := createInstanceFixture(t) mockInstance. @@ -470,7 +463,6 @@ func TestInstance_RunReadProgress_OnErrorReceived(t *testing.T) { assert.Equal(t, "mock error\nSYZFAIL: proxy app plugin error\n", output) } -// nolint: dupl func TestInstance_RunReadProgress_OnFinished(t *testing.T) { mockInstance, inst := createInstanceFixture(t) mockInstance. diff --git a/vm/vm_test.go b/vm/vm_test.go index 23e3f2c7d..860254dab 100644 --- a/vm/vm_test.go +++ b/vm/vm_test.go @@ -105,7 +105,6 @@ type Test struct { Report *report.Report } -// nolint: goconst // "DIAGNOSE\n", "BUG: bad\n" and "other output\n" var tests = []*Test{ { Name: "program-exits-normally", |
