aboutsummaryrefslogtreecommitdiffstats
path: root/vm
diff options
context:
space:
mode:
authorDmitry Vyukov <dvyukov@google.com>2017-11-29 17:53:07 +0100
committerDmitry Vyukov <dvyukov@google.com>2017-11-29 18:24:30 +0100
commit29b0fd90e6ac720fb21cc98ae89acfa6704b35bc (patch)
tree7f1bdb6c9a3d04b426bdfeec8a45ee032b6cba9a /vm
parent46c864566a5ce47fade185c639c9df7d9234380b (diff)
pkg/report: include Maintainers into report
Currently getting a complete report requires a complex, multi-step dance (including getting information that external users are not interested in -- guilty file). Simplify interface down to 2 functions: Parse and Symbolize. Parse does what it did before, Symbolize symbolizes report and fills in maintainers. This simplifies both implementations of Reporter interface and all users of the interface. Potentially we could get this down to 1 function Parse that does everything. However, (1) Symbolize can fail, while Parse cannot, (2) usually we want to ignore (log) Symbolize errors, but otherwise proceed with the report, (3) repro does not need symbolization for all but the last report.
Diffstat (limited to 'vm')
-rw-r--r--vm/vm.go2
1 files changed, 1 insertions, 1 deletions
diff --git a/vm/vm.go b/vm/vm.go
index f27185742..b59c0d223 100644
--- a/vm/vm.go
+++ b/vm/vm.go
@@ -100,7 +100,7 @@ func (inst *Instance) Close() {
// It detects kernel oopses in output, lost connections, hangs, etc.
// outc/errc is what vm.Instance.Run returns, reporter parses kernel output for oopses.
// If canExit is false and the program exits, it is treated as an error.
-// Returns crash report, or nil if no error happens.
+// Returns a non-symbolized crash report, or nil if no error happens.
func MonitorExecution(outc <-chan []byte, errc <-chan error, reporter report.Reporter, canExit bool) (
rep *report.Report) {
var output []byte