diff options
| author | Dmitry Vyukov <dvyukov@google.com> | 2020-10-26 10:51:06 +0100 |
|---|---|---|
| committer | Dmitry Vyukov <dvyukov@google.com> | 2020-10-26 15:44:28 +0100 |
| commit | e6e35dba937599d098fc034eff2686e5ddc409e9 (patch) | |
| tree | 802be708d0bc84dee01b9285639690a53f1f6f94 /vm/vmimpl/util.go | |
| parent | d46bc75207fea1d7671c1277dd660cf1a4d7847b (diff) | |
sys/targets: add OS/Arch name consts
We use strings to identify OS/Arch.
These strings are duplicated throughout the code base massively.
golangci-lint points to possiblity of typos and duplication.
We already had to define these names in pkg/csource
and disable checking for prog package. A future change triggers
such warnings in another package.
Add OS/Arch name consts to sys/targets so that they can be used
to refer to OS/Arch. Use the consts everywhere.
Diffstat (limited to 'vm/vmimpl/util.go')
| -rw-r--r-- | vm/vmimpl/util.go | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/vm/vmimpl/util.go b/vm/vmimpl/util.go index 418ae2d66..47340ccde 100644 --- a/vm/vmimpl/util.go +++ b/vm/vmimpl/util.go @@ -9,6 +9,7 @@ import ( "github.com/google/syzkaller/pkg/log" "github.com/google/syzkaller/pkg/osutil" + "github.com/google/syzkaller/sys/targets" ) // Sleep for d. @@ -24,7 +25,7 @@ func SleepInterruptible(d time.Duration) bool { func WaitForSSH(debug bool, timeout time.Duration, addr, sshKey, sshUser, OS string, port int, stop chan error) error { pwd := "pwd" - if OS == "windows" { + if OS == targets.Windows { pwd = "dir" } startTime := time.Now() |