aboutsummaryrefslogtreecommitdiffstats
path: root/vm/vm_test.go
diff options
context:
space:
mode:
authorDmitry Vyukov <dvyukov@google.com>2018-12-16 13:53:22 +0100
committerDmitry Vyukov <dvyukov@google.com>2018-12-16 13:54:07 +0100
commitc7e64e2b4f3a9d7734a92aebc53f285cd6afd94b (patch)
treebb55753c91c0076a65424d1eaf0142ca13475004 /vm/vm_test.go
parent4bc415c2305c2489109f79caf02b8a10fe5036bb (diff)
vm: don't call Diagnose when VM hasn't crashed
Fixes #875
Diffstat (limited to 'vm/vm_test.go')
-rw-r--r--vm/vm_test.go21
1 files changed, 14 insertions, 7 deletions
diff --git a/vm/vm_test.go b/vm/vm_test.go
index 1c66166f7..626ad62cb 100644
--- a/vm/vm_test.go
+++ b/vm/vm_test.go
@@ -107,11 +107,16 @@ var tests = []*Test{
Body: func(outc chan []byte, errc chan error) {
errc <- nil
},
+ },
+ {
+ Name: "#875-diagnose-bugs-2",
+ Body: func(outc chan []byte, errc chan error) {
+ errc <- nil
+ },
Report: &report.Report{
- Title: "BUG: DIAGNOSE",
- // TODO: this is wrong.
- Report: []byte(
- "BUG: DIAGNOSE\n",
+ Title: lostConnectionCrash,
+ Output: []byte(
+ "DIAGNOSE\n",
),
},
},
@@ -148,10 +153,9 @@ var tests = []*Test{
},
Report: &report.Report{
Title: "BUG: bad",
- // TODO: this is wrong.
Report: []byte(
- "DIAGNOSE\n" +
- "BUG: bad\n",
+ "BUG: bad\n" +
+ "DIAGNOSE\n",
),
},
},
@@ -298,4 +302,7 @@ func testMonitorExecution(t *testing.T, test *Test) {
if !bytes.Equal(test.Report.Report, rep.Report) {
t.Fatalf("want report:\n%s\n\ngot report:\n%s\n", test.Report.Report, rep.Report)
}
+ if test.Report.Output != nil && !bytes.Equal(test.Report.Output, rep.Output) {
+ t.Fatalf("want output:\n%s\n\ngot output:\n%s\n", test.Report.Output, rep.Output)
+ }
}