aboutsummaryrefslogtreecommitdiffstats
path: root/vendor/github.com/catenacyber
diff options
context:
space:
mode:
authordependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>2024-04-02 14:37:40 +0000
committerTaras Madan <tarasmadan@google.com>2024-04-03 09:59:40 +0000
commit9d2a90af8850a414d2da20b806d7aa8fd9a297ae (patch)
treeb6ce5a1bc2ecaed9f94b06b36eca20b98929970c /vendor/github.com/catenacyber
parentb90978ba49e3321a2d1cd77c07c196b088c97386 (diff)
mod: bump github.com/golangci/golangci-lint from 1.56.2 to 1.57.2
Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.56.2 to 1.57.2. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](https://github.com/golangci/golangci-lint/compare/v1.56.2...v1.57.2) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Diffstat (limited to 'vendor/github.com/catenacyber')
-rw-r--r--vendor/github.com/catenacyber/perfsprint/analyzer/analyzer.go12
1 files changed, 9 insertions, 3 deletions
diff --git a/vendor/github.com/catenacyber/perfsprint/analyzer/analyzer.go b/vendor/github.com/catenacyber/perfsprint/analyzer/analyzer.go
index ad312ca69..543b4bdbc 100644
--- a/vendor/github.com/catenacyber/perfsprint/analyzer/analyzer.go
+++ b/vendor/github.com/catenacyber/perfsprint/analyzer/analyzer.go
@@ -22,6 +22,7 @@ type perfSprint struct {
errorf bool
sprintf1 bool
fiximports bool
+ strconcat bool
}
func newPerfSprint() *perfSprint {
@@ -31,6 +32,7 @@ func newPerfSprint() *perfSprint {
errorf: true,
sprintf1: true,
fiximports: true,
+ strconcat: true,
}
}
@@ -47,6 +49,7 @@ func New() *analysis.Analyzer {
r.Flags.BoolVar(&n.errorf, "errorf", true, "optimizes fmt.Errorf")
r.Flags.BoolVar(&n.sprintf1, "sprintf1", true, "optimizes fmt.Sprintf with only one argument")
r.Flags.BoolVar(&n.fiximports, "fiximports", true, "fix needed imports from other fixes")
+ r.Flags.BoolVar(&n.strconcat, "strconcat", true, "optimizes into strings concatenation")
return r
}
@@ -59,6 +62,9 @@ func isConcatable(verb string) bool {
(strings.HasSuffix(verb, "%s") && !strings.Contains(verb, "%[1]s")) ||
(strings.HasSuffix(verb, "%[1]s") && !strings.Contains(verb, "%s"))
+ if strings.Count(verb, "%[1]s") > 1 {
+ return false
+ }
return (hasPrefix || hasSuffix) && !(hasPrefix && hasSuffix)
}
@@ -143,7 +149,7 @@ func (n *perfSprint) run(pass *analysis.Pass) (interface{}, error) {
switch verb {
default:
- if fn == "fmt.Sprintf" && isConcatable(verb) {
+ if fn == "fmt.Sprintf" && isConcatable(verb) && n.strconcat {
break
}
return
@@ -470,10 +476,10 @@ func (n *perfSprint) run(pass *analysis.Pass) (interface{}, error) {
d = &analysis.Diagnostic{
Pos: call.Pos(),
End: call.End(),
- Message: fn + " can be replaced with string addition",
+ Message: fn + " can be replaced with string concatenation",
SuggestedFixes: []analysis.SuggestedFix{
{
- Message: "Use string addition",
+ Message: "Use string concatenation",
TextEdits: []analysis.TextEdit{{
Pos: call.Pos(),
End: call.End(),