aboutsummaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authorDmitry Vyukov <dvyukov@google.com>2018-12-06 18:53:57 +0100
committerDmitry Vyukov <dvyukov@google.com>2018-12-06 18:56:08 +0100
commitab4b148b34b55427cf82f4dd67f0773aada301be (patch)
tree2e8c7b5c4ad7f7722a357b43bfbce68f2505ee69 /tools
parentceaec61a833bf78e2aa2a1feb964e1915d3f465b (diff)
prog: add Prog.Finalize
Prog.Finalize combines assignSizesCall, SanitizeCall and validate. Intended for users who build own programs, so that we don't need to expose all individual methods.
Diffstat (limited to 'tools')
-rw-r--r--tools/syz-trace2syz/proggen/proggen.go2
-rw-r--r--tools/syz-trace2syz/proggen/proggen_test.go2
-rw-r--r--tools/syz-trace2syz/trace2syz.go2
3 files changed, 2 insertions, 4 deletions
diff --git a/tools/syz-trace2syz/proggen/proggen.go b/tools/syz-trace2syz/proggen/proggen.go
index 4ba81d5b5..54d614670 100644
--- a/tools/syz-trace2syz/proggen/proggen.go
+++ b/tools/syz-trace2syz/proggen/proggen.go
@@ -33,7 +33,6 @@ func GenSyzProg(trace *parser.Trace, target *prog.Target, selector *CallSelector
if call == nil {
continue
}
- ctx.Target.AssignSizesCall(call)
ctx.Prog.Calls = append(ctx.Prog.Calls, call)
}
return ctx
@@ -60,7 +59,6 @@ func genCall(ctx *Context) *prog.Call {
syzCall.Args = append(syzCall.Args, res)
}
genResult(syzCall.Meta.Ret, straceCall.Ret, ctx)
- ctx.Target.SanitizeCall(syzCall)
return syzCall
}
diff --git a/tools/syz-trace2syz/proggen/proggen_test.go b/tools/syz-trace2syz/proggen/proggen_test.go
index 47a879333..c02ea57f7 100644
--- a/tools/syz-trace2syz/proggen/proggen_test.go
+++ b/tools/syz-trace2syz/proggen/proggen_test.go
@@ -40,7 +40,7 @@ func parseSingleTrace(t *testing.T, data string) *Context {
traceTree = parser.ParseLoop(data)
ctx = GenSyzProg(traceTree.TraceMap[traceTree.RootPid], target, selector)
ctx.FillOutMemory()
- if err := ctx.Prog.Validate(); err != nil {
+ if err := ctx.Prog.Finalize(); err != nil {
t.Fatalf("failed to parse trace: %s", err.Error())
}
return ctx
diff --git a/tools/syz-trace2syz/trace2syz.go b/tools/syz-trace2syz/trace2syz.go
index 745493186..3400004c8 100644
--- a/tools/syz-trace2syz/trace2syz.go
+++ b/tools/syz-trace2syz/trace2syz.go
@@ -85,7 +85,7 @@ func parseTraces(target *prog.Target) []*prog.Prog {
log.Logf(1, "failed to fill out memory: %v, skipping this prog", err)
continue
}
- if err := ctx.Prog.Validate(); err != nil {
+ if err := ctx.Prog.Finalize(); err != nil {
log.Fatalf("error validating program: %s", err)
}
if progIsTooLarge(ctx.Prog) {