diff options
| author | Dmitry Vyukov <dvyukov@google.com> | 2019-11-06 17:59:11 +0100 |
|---|---|---|
| committer | Dmitry Vyukov <dvyukov@google.com> | 2019-11-07 11:07:03 +0100 |
| commit | 30cb7f98cd1aba45565123caf4cbd73772bb8b58 (patch) | |
| tree | d43386f633ef60f4314d9d8ae2b02b0dea4af370 /tools/syz-testbuild/testbuild.go | |
| parent | f15876118387bb9e4c079f29d06394b36e393180 (diff) | |
pkg/bisect: detect wrong bisections
Detect bisection to merge commits and to commits that don't affect
kernel binary (comments, other arches, whitespaces, etc).
Such bisections are not reported in emails (but shown on web).
Update #1271
Diffstat (limited to 'tools/syz-testbuild/testbuild.go')
| -rw-r--r-- | tools/syz-testbuild/testbuild.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/syz-testbuild/testbuild.go b/tools/syz-testbuild/testbuild.go index a4db5be8a..fd5a0fea3 100644 --- a/tools/syz-testbuild/testbuild.go +++ b/tools/syz-testbuild/testbuild.go @@ -119,7 +119,7 @@ func main() { } } -func test(repo vcs.Repo, bisecter vcs.Bisecter, kernelConfig []byte, env instance.BuilderTester, com *vcs.Commit) { +func test(repo vcs.Repo, bisecter vcs.Bisecter, kernelConfig []byte, env instance.Env, com *vcs.Commit) { bisectEnv, err := bisecter.EnvForCommit(*flagBisectBin, com.Hash, kernelConfig) if err != nil { fail(err) @@ -128,7 +128,7 @@ func test(repo vcs.Repo, bisecter vcs.Bisecter, kernelConfig []byte, env instanc if err := build.Clean(*flagOS, *flagArch, vmType, *flagKernelSrc); err != nil { fail(err) } - _, err = env.BuildKernel(bisectEnv.Compiler, *flagUserspace, + _, _, err = env.BuildKernel(bisectEnv.Compiler, *flagUserspace, *flagKernelCmdline, *flagKernelSysctl, bisectEnv.KernelConfig) if err != nil { if verr, ok := err.(*osutil.VerboseError); ok { |