tools/syz-linter: add a check for fmt.Printf/Fprintf messages

1 files changed, 21 insertions, 11 deletions

diff --git a/tools/syz-linter/testdata/src/lintertest/lintertest.go b/tools/syz-linter/testdata/src/lintertest/lintertest.go
index 341108c0b..9fb1d89c9 100644
--- a/tools/syz-linter/testdata/src/lintertest/lintertest.go
+++ b/tools/syz-linter/testdata/src/lintertest/lintertest.go
@@ -6,6 +6,7 @@ package lintertest
 import (
 	"fmt"
 	"log"
+	"os"
 )
 
 /* some comment */ // want "Use C-style comments // instead of /* */"
@@ -49,29 +50,38 @@ func funcArgsBad0(a int, b int) { // want "Use 'a, b int'"
 }
 
 func funcArgsBad1() (a int, b int) { // want "Use 'a, b int'"
-	return 0, 0	// lower-case comment is OK
+	return 0, 0 // lower-case comment is OK
 }
 
 func funcArgsBad2(a int16, b, c uint32, d uint32, e int16) { // want "Use 'b, c, d uint32'"
 }
 
 func logErrorMessages() {
-	fmt.Errorf("good message")
-	fmt.Errorf("good message %v", 0)
 	msg := "good message"
+	err := fmt.Errorf("good message")
+	fmt.Errorf("good message %v", 0)
 	fmt.Errorf(msg)
 	log.Printf("good message")
 	log.Print("good message")
 	log.Print("Using.An.Identifier is ok as well")
 	log.Print(msg)
+	fmt.Printf("%s", msg)
+	fmt.Printf("fragment")
+	fmt.Printf("Fragment Fragment %s", msg)
+	fmt.Fprintf(nil, "These can be anything")
 
-	fmt.Errorf("Bad message")	// want "Don't start log/error messages with a Capital letter"
-	log.Fatalf("Bad message %v", 1) // want "Don't start log/error messages with a Capital letter"
-	log.Printf("Bad message %v", 1) // want "Don't start log/error messages with a Capital letter"
-	log.Print("Bad message") // want "Don't start log/error messages with a Capital letter"
-	log.Print("also ad message.") // want "Don't use period at the end of log/error messages"
-	log.Print("no new lines\n") // want "Don't use \\\\n at the end of log/error messages"
-	log.Print("") // want "Don't use empty log/error messages"
+	fmt.Errorf("Bad message")                                           // want "Don't start log/error messages with a Capital letter"
+	log.Fatalf("Bad message %v", 1)                                     // want "Don't start log/error messages with a Capital letter"
+	log.Printf("Bad message %v", 1)                                     // want "Don't start log/error messages with a Capital letter"
+	log.Print("Bad message")                                            // want "Don't start log/error messages with a Capital letter"
+	log.Print("also ad message.")                                       // want "Don't use period at the end of log/error messages"
+	log.Print("no new lines\n")                                         // want "Don't use \\\\n at the end of log/error messages"
+	log.Print("")                                                       // want "Don't use empty log/error messages"
+	fmt.Printf("Real output message with capital letter\n")             // want "Don't start log/error messages with a Capital letter"
+	fmt.Printf("real output message without newline")                   // want "Add \\\\n at the end of printed messages"
+	fmt.Fprintf(os.Stderr, "Real output message with capital letter\n") // want "Don't start log/error messages with a Capital letter"
+	fmt.Fprintf(os.Stderr, "real output message without newline")       // want "Add \\\\n at the end of printed messages"
+	fmt.Fprintf(os.Stderr, "%v", err)                                   // want "Add \\\\n at the end of printed messages"
 }
 
 func varDecls() {
@@ -79,6 +89,6 @@ func varDecls() {
 	b := 0
 	c := int64(0)
 	var _ int = 0
-	var d int = 0	// want "Don't use both var, type and value in variable declarations"
+	var d int = 0 // want "Don't use both var, type and value in variable declarations"
 	_, _, _, _ = a, b, c, d
 }