aboutsummaryrefslogtreecommitdiffstats
path: root/tools/syz-linter/testdata
diff options
context:
space:
mode:
authorDmitry Vyukov <dvyukov@google.com>2020-07-05 09:47:42 +0200
committerDmitry Vyukov <dvyukov@google.com>2020-07-05 10:55:16 +0200
commit214e3e269cce39f25d2552d3ba994cced679d5e8 (patch)
treee8f0ed5aa35e286f87869d4efde8f01fec6bacc4 /tools/syz-linter/testdata
parent3940e7a64fa27c338ca1283b8f90143412b281ba (diff)
tools/syz-linter: check log/error text starting with capital letter
Update #1876
Diffstat (limited to 'tools/syz-linter/testdata')
-rw-r--r--tools/syz-linter/testdata/src/lintertest/lintertest.go21
1 files changed, 21 insertions, 0 deletions
diff --git a/tools/syz-linter/testdata/src/lintertest/lintertest.go b/tools/syz-linter/testdata/src/lintertest/lintertest.go
index 69b956e80..c44f61683 100644
--- a/tools/syz-linter/testdata/src/lintertest/lintertest.go
+++ b/tools/syz-linter/testdata/src/lintertest/lintertest.go
@@ -3,6 +3,11 @@
package lintertest
+import (
+ "fmt"
+ "log"
+)
+
/* some comment */ // want "Use C-style comments // instead of /* */"
var comment = 1 /* some comment */ // want "Use C-style comments // instead of /* */"
@@ -42,3 +47,19 @@ func funcArgsBad1() (a int, b int) { // want "Use 'a, b int'"
func funcArgsBad2(a int16, b, c uint32, d uint32, e int16) { // want "Use 'b, c, d uint32'"
}
+
+func logErrorMessages() {
+ fmt.Errorf("good message")
+ fmt.Errorf("good message %v", 0)
+ msg := "good message"
+ fmt.Errorf(msg)
+ log.Printf("good message")
+ log.Print("good message")
+ log.Print("Using.An.Identifier is ok as well")
+ log.Print(msg)
+
+ fmt.Errorf("Bad message") // want "bad log/error"
+ log.Fatalf("Bad message %v", 1) // want "bad log/error"
+ log.Printf("Bad message %v", 1) // want "bad log/error"
+ log.Print("Bad message") // want "bad log/error"
+}