diff options
| author | Taras Madan <tarasmadan@google.com> | 2022-04-01 10:26:29 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-04-01 10:26:29 +0200 |
| commit | b183f42084053cef8655b51955080cb0b69ce93b (patch) | |
| tree | 3cfa1113e58a66471c734ab1426159ea5d03c552 /syz-verifier | |
| parent | 68fc921ad90a9ed3604448913e66d02ea8d11de6 (diff) | |
syz-verifier: simplify Stats API
Diffstat (limited to 'syz-verifier')
| -rw-r--r-- | syz-verifier/stats.go | 13 | ||||
| -rw-r--r-- | syz-verifier/verifier.go | 3 |
2 files changed, 8 insertions, 8 deletions
diff --git a/syz-verifier/stats.go b/syz-verifier/stats.go index 3815e3898..41ffb7848 100644 --- a/syz-verifier/stats.go +++ b/syz-verifier/stats.go @@ -60,12 +60,6 @@ func (stat *StatMapStringToCallStats) IncCallOccurrenceCount(key string) { stat.mu.Unlock() } -func (stat *StatMapStringToCallStats) IncMismatches(key string) { - stat.mu.Lock() - stat.mapStringToCallStats[key].Mismatches++ - stat.mu.Unlock() -} - func (stat *StatMapStringToCallStats) AddState(key string, state ReturnState) { stat.mu.Lock() stat.mapStringToCallStats[key].States[state] = true @@ -136,6 +130,13 @@ func (stats *Stats) MismatchesFound() bool { return stats.TotalCallMismatches.Get() != 0 } +func (stats *Stats) IncCallMismatches(key string) { + stats.mu.Lock() + defer stats.mu.Unlock() + stats.Calls.mapStringToCallStats[key].Mismatches++ + stats.TotalCallMismatches.uint64++ +} + // CallStats stores information used to generate statistics for the // system call. type CallStats struct { diff --git a/syz-verifier/verifier.go b/syz-verifier/verifier.go index 19182fcba..dce8a99c6 100644 --- a/syz-verifier/verifier.go +++ b/syz-verifier/verifier.go @@ -317,8 +317,7 @@ func (vrf *Verifier) AddCallsExecutionStat(results []*ExecResult, program *prog. if !cr.Mismatch { continue } - vrf.stats.Calls.IncMismatches(cr.Call) - vrf.stats.TotalCallMismatches.Inc() + vrf.stats.IncCallMismatches(cr.Call) for _, state := range cr.States { if state0 := cr.States[0]; state0 != state { vrf.stats.Calls.AddState(cr.Call, state) |
