all: use `t.TempDir` to create temporary test directory

This commit replaces all `ioutil.TempDir` with `t.TempDir` in tests.
The directory created by `t.TempDir` is automatically removed when the
test and all its subtests complete.

Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>

1 files changed, 1 insertions, 14 deletions

diff --git a/syz-hub/state/state_test.go b/syz-hub/state/state_test.go
index 8db7a30f6..ad90d6aaf 100644
--- a/syz-hub/state/state_test.go
+++ b/syz-hub/state/state_test.go
@@ -4,8 +4,6 @@
 package state
 
 import (
-	"io/ioutil"
-	"os"
 	"sort"
 	"testing"
 
@@ -21,22 +19,14 @@ type TestState struct {
 
 func MakeTestState(t *testing.T) *TestState {
 	t.Parallel()
-	dir, err := ioutil.TempDir("", "syz-hub-state-test")
-	if err != nil {
-		t.Fatalf("failed to create temp dir: %v", err)
-	}
+	dir := t.TempDir()
 	state, err := Make(dir)
 	if err != nil {
-		os.RemoveAll(dir)
 		t.Fatalf("failed to make state: %v", err)
 	}
 	return &TestState{t, dir, state}
 }
 
-func (ts *TestState) Close() {
-	os.RemoveAll(ts.dir)
-}
-
 func (ts *TestState) Reload() {
 	ts.state.Flush()
 	state, err := Make(ts.dir)
@@ -86,7 +76,6 @@ func (ts *TestState) PendingRepro(name string) []byte {
 
 func TestBasic(t *testing.T) {
 	st := MakeTestState(t)
-	defer st.Close()
 
 	if _, _, _, err := st.state.Sync("foo", nil, nil); err == nil {
 		t.Fatalf("synced with unconnected manager")
@@ -98,7 +87,6 @@ func TestBasic(t *testing.T) {
 
 func TestRepro(t *testing.T) {
 	st := MakeTestState(t)
-	defer st.Close()
 
 	st.Connect("foo", "", false, []string{"open", "read", "write"}, nil)
 	st.Connect("bar", "", false, []string{"open", "read", "close"}, nil)
@@ -137,7 +125,6 @@ func TestRepro(t *testing.T) {
 
 func TestDomain(t *testing.T) {
 	st := MakeTestState(t)
-	defer st.Close()
 
 	st.Connect("client0", "", false, []string{"open"}, nil)
 	st.Connect("client1", "domain1", false, []string{"open"}, nil)