diff options
| author | Aleksandr Nogikh <nogikh@google.com> | 2022-04-13 09:01:37 +0000 |
|---|---|---|
| committer | Aleksandr Nogikh <wp32pw@gmail.com> | 2022-04-13 11:57:51 +0200 |
| commit | c93be2342ceb683ac38c3f5189df000446df8e6a (patch) | |
| tree | c12650be934f913bff1faf61d4f33e1fef484fc0 /syz-ci | |
| parent | faabdb8662cdd4c886f2229ac917ae0b8a311943 (diff) | |
syz-ci: don't require a repro for JobTestPatch
For boot-time bugs there may be no repro, yet we can test it. Only leave
a sanity check (if syz repro is present, then repro options must also
be, and vice versa).
Diffstat (limited to 'syz-ci')
| -rw-r--r-- | syz-ci/jobs.go | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/syz-ci/jobs.go b/syz-ci/jobs.go index 605ddaf7b..9d3e0df25 100644 --- a/syz-ci/jobs.go +++ b/syz-ci/jobs.go @@ -337,8 +337,10 @@ func (jp *JobProcessor) process(job *Job) *dashapi.JobDoneReq { {"kernel branch", req.KernelBranch != "" || req.Type != dashapi.JobTestPatch}, {"kernel config", len(req.KernelConfig) != 0}, {"syzkaller commit", req.SyzkallerCommit != ""}, - {"reproducer options", len(req.ReproOpts) != 0}, - {"reproducer program", len(req.ReproSyz) != 0}, + // We either want a normal repro (with options and syz repro text) + // or it's a boot time bug, in which case both are empty. + {"reproducer consistency", (len(req.ReproOpts) != 0 && len(req.ReproSyz) != 0) || + (len(req.ReproOpts) == 0 && len(req.ReproSyz) == 0)}, } for _, req := range required { if !req.ok { |