diff options
| author | Aleksandr Nogikh <nogikh@google.com> | 2021-07-14 17:01:48 +0000 |
|---|---|---|
| committer | Aleksandr Nogikh <wp32pw@gmail.com> | 2021-07-20 13:39:45 +0200 |
| commit | b5969a9bdd1769ae7dc56682c4dbb8bc8f2ab7c3 (patch) | |
| tree | 1859559654383d8f1b771ece935aca6a1b6371c0 /syz-ci | |
| parent | bc48c9ab65ed47d707bedef64ca52e1a5c383250 (diff) | |
all: remove pointers to pkg.build.Params
The struct pkg.build.Params is currently primarily passed on as a
pointer, which leads make it hard to see the places, where it can
(and should) actually be modified.
Make it all more explicit by only passing pointer references to objects
of this type when the object is expected to be modified by the function.
In fact, at this moment there are no such situations.
Diffstat (limited to 'syz-ci')
| -rw-r--r-- | syz-ci/manager.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/syz-ci/manager.go b/syz-ci/manager.go index 7d548ff7b..90e43d472 100644 --- a/syz-ci/manager.go +++ b/syz-ci/manager.go @@ -304,7 +304,7 @@ func (mgr *Manager) build(kernelCommit *vcs.Commit) error { if err := config.SaveFile(filepath.Join(tmpDir, "tag"), info); err != nil { return fmt.Errorf("failed to write tag file: %v", err) } - params := &build.Params{ + params := build.Params{ TargetOS: mgr.managercfg.TargetOS, TargetArch: mgr.managercfg.TargetVMArch, VMType: mgr.managercfg.Type, |