diff options
| author | Dmitry Vyukov <dvyukov@google.com> | 2022-01-06 18:34:45 +0100 |
|---|---|---|
| committer | Dmitry Vyukov <dvyukov@google.com> | 2022-01-11 16:30:08 +0100 |
| commit | f9379c776e786ca412b32d6f2bcd81015bba47c4 (patch) | |
| tree | 2005e76de5aae6ad9d7f4a735a505bf7710ed21b /sys/linux/fs_ioctl_fscrypt.txt | |
| parent | 14cc59eef8374ac8013a05d5d14c4cd4af9d0979 (diff) | |
sys/linux: don't use len/flags/const/proc types in out fields
Remove all uses of len/flags/const/proc types in explicitly marked out fields.
Use of these types for out fields does not make sense:
a len[b, int32] (out)
b flags[foo, int32] (out)
Since kernel fills these fields, that's unnecessary details or bugs in descriptions.
In particular all of these are actually bugs:
ioctl$TUNSETQUEUE(fd fd_tun, cmd const[TUNSETQUEUE], arg ptr[in, ifreq_t[flags[tun_queue_flags, int16]]])
ioctl$TUNSETIFF(fd fd_tun, cmd const[TUNSETIFF], arg ptr[in, ifreq_t[flags[tun_setiff_flags, int16]]])
ioctl$SIOCSIFHWADDR(fd fd_tun, cmd const[SIOCSIFHWADDR], arg ptr[in, ifreq_t[mac_addr]])
ioctl$sock_inet_SIOCSIFADDR(fd sock, cmd const[SIOCSIFADDR], arg ptr[inout, ifreq_t[sockaddr_in]])
ioctl$sock_inet_SIOCSIFBRDADDR(fd sock, cmd const[SIOCSIFBRDADDR], arg ptr[inout, ifreq_t[sockaddr_in]])
ioctl$sock_inet_SIOCSIFNETMASK(fd sock, cmd const[SIOCSIFNETMASK], arg ptr[inout, ifreq_t[sockaddr_in]])
ioctl$sock_inet_SIOCSIFDSTADDR(fd sock, cmd const[SIOCSIFDSTADDR], arg ptr[inout, ifreq_t[sockaddr_in]])
ioctl$sock_inet_SIOCSIFPFLAGS(fd sock, cmd const[SIOCSIFPFLAGS], arg ptr[inout, ifreq_t[int32]])
ioctl$SIOCSIFMTU(fd sock_pppl2tp, cmd const[SIOCSIFMTU], arg ptr[in, ifreq_t[int32]])
ioctl$sock_SIOCETHTOOL(fd sock, cmd const[SIOCETHTOOL], arg ptr[inout, ifreq_t[ptr[inout, ethtool_cmd_u]]])
We pretend that we pass in some flags or addresses, but the ifreq field
was marked as (out), so we actually did not pass anything in.
Diffstat (limited to 'sys/linux/fs_ioctl_fscrypt.txt')
| -rw-r--r-- | sys/linux/fs_ioctl_fscrypt.txt | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/sys/linux/fs_ioctl_fscrypt.txt b/sys/linux/fs_ioctl_fscrypt.txt index 00ca9c29a..f4e4635a6 100644 --- a/sys/linux/fs_ioctl_fscrypt.txt +++ b/sys/linux/fs_ioctl_fscrypt.txt @@ -180,7 +180,7 @@ fscrypt_add_key_arg { fscrypt_remove_key_arg { key_spec fscrypt_key_specifier (in) - removal_status_flags const[0, int32] (out) + removal_status_flags int32 (out) reserved array[const[0, int32], 5] (in) } @@ -188,8 +188,8 @@ fscrypt_get_key_status_arg { key_spec fscrypt_key_specifier (in) reserved array[const[0, int32], 6] (in) - status const[0, int32] (out) - status_flags const[0, int32] (out) - user_count const[0, int32] (out) + status int32 (out) + status_flags int32 (out) + user_count int32 (out) out_reserved array[const[0, int32], 13] (out) } |