diff options
| author | Aleksandr Nogikh <nogikh@google.com> | 2024-03-06 14:47:02 +0100 |
|---|---|---|
| committer | Aleksandr Nogikh <nogikh@google.com> | 2024-03-08 10:56:47 +0000 |
| commit | 4097c8d7a8596ddbc9a9db7b7f39c5cbdb1bd742 (patch) | |
| tree | 453b39ea237785218a551d24d6c474db317aa951 /prog/prog.go | |
| parent | 6387f6b7d487e2a77d753ad28c1074e39c17c3ca (diff) | |
sys/linux: clone args before mutation
Not cloning the argument results in replaceArg() replacing a union
argument with itself, which may lead to inconsistent resource
references.
Add an assertion to detect such cases in the future.
Diffstat (limited to 'prog/prog.go')
| -rw-r--r-- | prog/prog.go | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/prog/prog.go b/prog/prog.go index f93293b64..da6f158bc 100644 --- a/prog/prog.go +++ b/prog/prog.go @@ -354,6 +354,9 @@ func (p *Prog) insertBefore(c *Call, calls []*Call) { // replaceArg replaces arg with arg1 in a program. func replaceArg(arg, arg1 Arg) { + if arg == arg1 { + panic("replacing an argument with itself") + } switch a := arg.(type) { case *ConstArg: *a = *arg1.(*ConstArg) |