all: refactor fault injection into call props

Now that call properties mechanism is implemented, we can refactor
fault injection.

Unfortunately, it is impossible to remove all traces of the previous apprach.
In reprolist and while performing syz-ci jobs, syzkaller still needs to
parse the old format.

Remove the old prog options-based approach whenever possible and replace
it with the use of call properties.

1 files changed, 2 insertions, 4 deletions

diff --git a/prog/encoding.go b/prog/encoding.go
index 3f1c918a7..9161da6b2 100644
--- a/prog/encoding.go
+++ b/prog/encoding.go
@@ -81,11 +81,9 @@ func (ctx *serializer) call(c *Call) {
 	}
 	ctx.printf(")")
 
-	defaultProps := DefaultCallProps()
 	anyChangedProps := false
 	c.Props.ForeachProp(func(name, key string, value reflect.Value) {
-		defaultValue := reflect.ValueOf(defaultProps).FieldByName(name)
-		if reflect.DeepEqual(value.Interface(), defaultValue.Interface()) {
+		if value.IsZero() {
 			return
 		}
 
@@ -352,7 +350,7 @@ func (p *parser) parseProg() (*Prog, error) {
 
 func (p *parser) parseCallProps() CallProps {
 	nameToValue := map[string]reflect.Value{}
-	callProps := DefaultCallProps()
+	callProps := CallProps{}
 	callProps.ForeachProp(func(_, key string, value reflect.Value) {
 		nameToValue[key] = value
 	})