prog: refactor bitfields representation

All callers of BitfieldMiddle just want static size (0 for middle).
Make it so: Size for middle bitfields just returns 0. Removes lots of if's.
Introduce Type.UnitSize, which now holds the underlying type for bitfields.
This will be needed to fix #1542 b/c even if UnitSize=4 for last bitfield
Size can be anywhere from 0 to 4 (not necessary equal to UnitSize due to overlapping).

1 files changed, 3 insertions, 5 deletions

diff --git a/prog/analysis.go b/prog/analysis.go
index f8330ed1c..519d5ba84 100644
--- a/prog/analysis.go
+++ b/prog/analysis.go
@@ -134,11 +134,9 @@ func foreachArgImpl(arg Arg, ctx ArgCtx, f func(Arg, *ArgCtx)) {
 		var totalSize uint64
 		for _, arg1 := range a.Inner {
 			foreachArgImpl(arg1, ctx, f)
-			if !arg1.Type().BitfieldMiddle() {
-				size := arg1.Size()
-				ctx.Offset += size
-				totalSize += size
-			}
+			size := arg1.Size()
+			ctx.Offset += size
+			totalSize += size
 		}
 		claimedSize := a.Size()
 		varlen := a.Type().Varlen()