aboutsummaryrefslogtreecommitdiffstats
path: root/pkg
diff options
context:
space:
mode:
authorDmitry Vyukov <dvyukov@google.com>2018-02-18 09:31:12 +0100
committerDmitry Vyukov <dvyukov@google.com>2018-02-19 21:48:20 +0100
commitdd768bf1c623521b27d1b16ab50a7b80cbcf8b37 (patch)
treeb6f686e750447c27343bfd06e3bd7eb6172468a6 /pkg
parent833f78c7b023badf3ac188005adaf5fb1a20f56e (diff)
prog: reorder Minimize arguments
Make the predicate the last argument. It's more common and convenient (arguments are not separated by multiple lines).
Diffstat (limited to 'pkg')
-rw-r--r--pkg/repro/repro.go17
1 files changed, 9 insertions, 8 deletions
diff --git a/pkg/repro/repro.go b/pkg/repro/repro.go
index bbe0e2d7c..fc79f5a8a 100644
--- a/pkg/repro/repro.go
+++ b/pkg/repro/repro.go
@@ -428,14 +428,15 @@ func (ctx *context) minimizeProg(res *Result) (*Result, error) {
if res.Opts.Fault {
call = res.Opts.FaultCall
}
- res.Prog, res.Opts.FaultCall = prog.Minimize(res.Prog, call, func(p1 *prog.Prog, callIndex int) bool {
- crashed, err := ctx.testProg(p1, res.Duration, res.Opts)
- if err != nil {
- ctx.reproLog(0, "minimization failed with %v", err)
- return false
- }
- return crashed
- }, true)
+ res.Prog, res.Opts.FaultCall = prog.Minimize(res.Prog, call, true,
+ func(p1 *prog.Prog, callIndex int) bool {
+ crashed, err := ctx.testProg(p1, res.Duration, res.Opts)
+ if err != nil {
+ ctx.reproLog(0, "minimization failed with %v", err)
+ return false
+ }
+ return crashed
+ })
return res, nil
}