pkg/report: improve netdev reports titles

3 files changed, 191 insertions, 0 deletions

diff --git a/pkg/report/linux.go b/pkg/report/linux.go
index 8ea126168..fa1299c22 100644
--- a/pkg/report/linux.go
+++ b/pkg/report/linux.go
@@ -767,6 +767,8 @@ var linuxStackParams = &stackParams{
 		"get_device_parent",
 		"device_add",
 		"finish_wait",
+		"rollback_registered",
+		"unregister_netdev",
 	},
 	corruptedLines: []*regexp.Regexp{
 		// Fault injection stacks are frequently intermixed with crash reports.
diff --git a/pkg/report/testdata/linux/report/411 b/pkg/report/testdata/linux/report/411
new file mode 100644
index 000000000..3d4a55e2b
--- /dev/null
+++ b/pkg/report/testdata/linux/report/411
@@ -0,0 +1,79 @@
+TITLE: WARNING in r871xu_dev_remove
+
+[   26.966491][  T101] ------------[ cut here ]------------
+[   26.974331][ T1737] usb 5-1: Direct firmware load for rtlwifi/rtl8712u.bin failed with error -2
+[   26.978202][  T101] WARNING: CPU: 0 PID: 101 at net/core/dev.c:8167 rollback_registered_many.cold+0x41/0x1bc
+[   26.987452][ T1737] usb 5-1: r8712u: Firmware request failed
+[   26.996887][  T101] Kernel panic - not syncing: panic_on_warn set ...
+[   26.996902][  T101] CPU: 0 PID: 101 Comm: kworker/0:2 Not tainted 5.3.0-rc4+ #26
+[   26.996910][  T101] Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
+[   26.996926][  T101] Workqueue: usb_hub_wq hub_event
+[   26.996933][  T101] Call Trace:
+[   26.996950][  T101]  dump_stack+0xca/0x13e
+[   26.996970][  T101]  ? rollback_registered_many.cold+0x4/0x1bc
+[   26.996988][  T101]  panic+0x2a3/0x6da
+[   27.003322][ T1737] usb 2-1: Direct firmware load for rtlwifi/rtl8712u.bin failed with error -2
+[   27.009556][  T101]  ? add_taint.cold+0x16/0x16
+[   27.009572][  T101]  ? __probe_kernel_read+0x188/0x1d0
+[   27.009583][  T101]  ? __warn.cold+0x5/0x4a
+[   27.009592][  T101]  ? __warn+0xe3/0x1e0
+[   27.009606][  T101]  ? rollback_registered_many.cold+0x41/0x1bc
+[   27.009615][  T101]  __warn.cold+0x20/0x4a
+[   27.009627][  T101]  ? __irq_work_queue_local+0xa3/0xe0
+[   27.009639][  T101]  ? rollback_registered_many.cold+0x41/0x1bc
+[   27.009651][  T101]  report_bug+0x262/0x2a0
+[   27.009671][  T101]  do_error_trap+0x12b/0x1e0
+[   27.034511][ T1737] usb 2-1: r8712u: Firmware request failed
+[   27.037337][  T101]  ? rollback_registered_many.cold+0x41/0x1bc
+[   27.037352][  T101]  do_invalid_op+0x32/0x40
+[   27.037366][  T101]  ? rollback_registered_many.cold+0x41/0x1bc
+[   27.037378][  T101]  invalid_op+0x23/0x30
+[   27.037398][  T101] RIP: 0010:rollback_registered_many.cold+0x41/0x1bc
+[   27.142564][  T101] Code: ff e8 c7 17 90 fc 48 c7 c7 00 e8 63 86 e8 24 b8 7a fc 0f 0b e9 93 be ff ff e8 af 17 90 fc 48 c7 c7 00 e8 63 86 e8 0c b8 7a fc <0f> 0b 4c 89 e7 e8 f9 0a 34 fd 31 ff 41 89 c4 89 c6 e8 bd 18 90 fc
+[   27.162178][  T101] RSP: 0018:ffff8881d505f6a8 EFLAGS: 00010286
+[   27.168229][  T101] RAX: 0000000000000024 RBX: ffff8881d2918000 RCX: 0000000000000000
+[   27.176185][  T101] RDX: 0000000000000000 RSI: ffffffff81288cfd RDI: ffffed103aa0bec7
+[   27.184168][  T101] RBP: ffff8881d505f7d8 R08: 0000000000000024 R09: ffffed103b645d58
+[   27.192164][  T101] R10: ffffed103b645d57 R11: ffff8881db22eabf R12: ffff8881d2918070
+[   27.200168][  T101] R13: ffff8881d505f768 R14: dffffc0000000000 R15: 0000000000000000
+[   27.208146][  T101]  ? vprintk_func+0x7d/0x113
+[   27.212725][  T101]  ? rollback_registered_many.cold+0x41/0x1bc
+[   27.218798][  T101]  ? generic_xdp_install+0x480/0x480
+[   27.224134][  T101]  ? __mutex_lock+0x430/0x1360
+[   27.228886][  T101]  ? do_raw_spin_lock+0x11a/0x280
+[   27.233931][  T101]  ? unregister_netdev+0xe/0x20
+[   27.238772][  T101]  ? mark_held_locks+0x9f/0xe0
+[   27.243538][  T101]  ? _raw_spin_unlock_irq+0x24/0x30
+[   27.248824][  T101]  ? mutex_trylock+0x2c0/0x2c0
+[   27.253605][  T101]  rollback_registered+0xf2/0x1c0
+[   27.258619][  T101]  ? rollback_registered_many+0xc70/0xc70
+[   27.264340][  T101]  ? wait_for_completion_interruptible+0x420/0x420
+[   27.271069][  T101]  ? wake_up_q+0xf0/0xf0
+[   27.275346][  T101]  unregister_netdevice_queue+0x1d7/0x2b0
+[   27.281338][  T101]  unregister_netdev+0x18/0x20
+[   27.286113][  T101]  r871xu_dev_remove+0xe2/0x215
+[   27.291003][  T101]  usb_unbind_interface+0x1bd/0x8a0
+[   27.296248][  T101]  ? usb_autoresume_device+0x60/0x60
+[   27.301608][  T101]  device_release_driver_internal+0x42f/0x500
+[   27.307702][  T101]  bus_remove_device+0x2dc/0x4a0
+[   27.312628][  T101]  device_del+0x420/0xb10
+[   27.317511][  T101]  ? __device_links_no_driver+0x240/0x240
+[   27.323349][  T101]  ? lockdep_hardirqs_on+0x379/0x580
+[   27.328733][  T101]  ? remove_intf_ep_devs+0x13f/0x1d0
+[   27.334034][  T101]  usb_disable_device+0x211/0x690
+[   27.339051][  T101]  usb_disconnect+0x284/0x8d0
+[   27.343966][  T101]  hub_event+0x1454/0x3640
+[   27.348381][  T101]  ? find_held_lock+0x2d/0x110
+[   27.353128][  T101]  ? mark_held_locks+0xe0/0xe0
+[   27.357885][  T101]  ? hub_port_debounce+0x260/0x260
+[   27.363039][  T101]  process_one_work+0x92b/0x1530
+[   27.367968][  T101]  ? pwq_dec_nr_in_flight+0x310/0x310
+[   27.369585][   T22] usb 1-1: new high-speed USB device number 3 using dummy_hcd
+[   27.373329][  T101]  ? do_raw_spin_lock+0x11a/0x280
+[   27.373343][  T101]  worker_thread+0x7ab/0xe20
+[   27.373358][  T101]  ? process_one_work+0x1530/0x1530
+[   27.373370][  T101]  kthread+0x318/0x420
+[   27.373382][  T101]  ? kthread_create_on_node+0xf0/0xf0
+[   27.373396][  T101]  ret_from_fork+0x24/0x30
+[   27.381295][  T101] Kernel Offset: disabled
+[   27.414812][  T101] Rebooting in 86400 seconds..
diff --git a/pkg/report/testdata/linux/report/412 b/pkg/report/testdata/linux/report/412
new file mode 100644
index 000000000..326028b8e
--- /dev/null
+++ b/pkg/report/testdata/linux/report/412
@@ -0,0 +1,110 @@
+TITLE: WARNING in default_device_exit_batch
+
+[  794.553848] WARNING: CPU: 0 PID: 21 at net/core/dev.c:8022 rollback_registered_many+0xeca/0x1250
+[  794.562851] Kernel panic - not syncing: panic_on_warn set ...
+[  794.568712] CPU: 0 PID: 21 Comm: kworker/u4:1 Not tainted 4.20.0-rc2+ #116
+[  794.575698] Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
+[  794.585053] Workqueue: netns cleanup_net
+[  794.589098] Call Trace:
+[  794.591669]  dump_stack+0x244/0x39d
+[  794.595288]  ? dump_stack_print_info.cold.1+0x20/0x20
+[  794.600467]  panic+0x2ad/0x55c
+[  794.603639]  ? add_taint.cold.5+0x16/0x16
+[  794.607782]  ? __warn.cold.8+0x5/0x45
+[  794.611559]  ? __warn+0xe8/0x1d0
+[  794.614920]  ? rollback_registered_many+0xeca/0x1250
+[  794.620000]  __warn.cold.8+0x20/0x45
+[  794.623692]  ? rcu_softirq_qs+0x20/0x20
+[  794.627645]  ? rollback_registered_many+0xeca/0x1250
+[  794.632730]  report_bug+0x254/0x2d0
+[  794.636443]  do_error_trap+0x11b/0x200
+[  794.640313]  do_invalid_op+0x36/0x40
+[  794.644013]  ? rollback_registered_many+0xeca/0x1250
+[  794.649107]  invalid_op+0x14/0x20
+[  794.652539] RIP: 0010:rollback_registered_many+0xeca/0x1250
+[  794.658228] Code: 57 19 00 00 48 c7 c6 e0 dd bc 88 48 c7 c7 20 de bc 88 c6 05 98 4d e2 03 01 e8 42 7f 18 fb 0f 0b e9 a6 f9 ff ff e8 c6 1b 4f fb <0f> 0b e9 7b f9 ff ff e8 ba 1b 4f fb 0f 0b e9 ea f9 ff ff e8 ae 1b
+[  794.677104] RSP: 0018:ffff8881d9467058 EFLAGS: 00010293
+[  794.682443] RAX: ffff8881d945a580 RBX: ffff8881bef64940 RCX: ffffffff86306593
+[  794.689692] RDX: 0000000000000000 RSI: ffffffff86306c1a RDI: 0000000000000001
+[  794.696940] RBP: ffff8881d94672a0 R08: ffff8881d945a580 R09: fffffbfff13e1a38
+[  794.704187] R10: fffffbfff13e1a38 R11: ffffffff89f0d1c7 R12: dffffc0000000000
+[  794.711434] R13: 0000000000000001 R14: ffffffff8494d7c0 R15: ffff8881d9467138
+[  794.718687]  ? bond_do_ioctl+0xae0/0xae0
+[  794.722729]  ? rollback_registered_many+0x843/0x1250
+[  794.727835]  ? rollback_registered_many+0xeca/0x1250
+[  794.733056]  ? rollback_registered_many+0xeca/0x1250
+[  794.738156]  ? generic_xdp_install+0x590/0x590
+[  794.742750]  ? __sanitizer_cov_trace_const_cmp4+0x16/0x20
+[  794.748276]  ? check_preemption_disabled+0x48/0x280
+[  794.753274]  ? __lock_is_held+0xb5/0x140
+[  794.757326]  ? __sanitizer_cov_trace_const_cmp8+0x18/0x20
+[  794.762845]  ? rtnl_is_locked+0xb5/0xf0
+[  794.766794]  ? rtnl_trylock+0x20/0x20
+[  794.770574]  ? __sanitizer_cov_trace_const_cmp8+0x18/0x20
+[  794.776090]  ? rtnl_is_locked+0xb5/0xf0
+[  794.780064]  ? rtnl_trylock+0x20/0x20
+[  794.783839]  ? __sanitizer_cov_trace_const_cmp1+0x1a/0x20
+[  794.789355]  ? unregister_netdevice_queue+0x2c0/0x5e0
+[  794.794540]  unregister_netdevice_many+0xfa/0x4c0
+[  794.799362]  ? unregister_netdev+0x30/0x30
+[  794.803578]  ? sysfs_remove_group+0xf6/0x1b0
+[  794.807969]  ? br_dev_delete+0x139/0x190
+[  794.812137]  default_device_exit_batch+0x43a/0x540
+[  794.817054]  ? unregister_netdevice_many+0x4c0/0x4c0
+[  794.822140]  ? default_device_exit+0x224/0x2c0
+[  794.826792]  ? __init_waitqueue_head+0x150/0x150
+[  794.831528]  ? rtnl_unlock+0xe/0x10
+[  794.835140]  ? unregister_netdevice_many+0x4c0/0x4c0
+[  794.840217]  ? dev_change_net_namespace+0xe50/0xe50
+[  794.845208]  ops_exit_list.isra.5+0x105/0x160
+[  794.849684]  cleanup_net+0x555/0xb10
+[  794.853375]  ? peernet2id_alloc+0x3e0/0x3e0
+[  794.857672]  ? find_held_lock+0x36/0x1c0
+[  794.861714]  ? zap_class+0x640/0x640
+[  794.865425]  ? __sanitizer_cov_trace_const_cmp4+0x16/0x20
+[  794.871247]  ? check_preemption_disabled+0x48/0x280
+[  794.876250]  ? __lock_is_held+0xb5/0x140
+[  794.880296]  process_one_work+0xc90/0x1c40
+[  794.884521]  ? mark_held_locks+0x130/0x130
+[  794.888859]  ? pwq_dec_nr_in_flight+0x4a0/0x4a0
+[  794.893513]  ? __switch_to_asm+0x40/0x70
+[  794.897571]  ? __switch_to_asm+0x34/0x70
+[  794.901607]  ? __switch_to_asm+0x34/0x70
+[  794.905645]  ? __switch_to_asm+0x40/0x70
+[  794.909683]  ? __switch_to_asm+0x34/0x70
+[  794.913720]  ? __switch_to_asm+0x40/0x70
+[  794.917771]  ? __switch_to_asm+0x34/0x70
+[  794.921824]  ? __switch_to_asm+0x40/0x70
+[  794.925863]  ? __schedule+0x8d7/0x21d0
+[  794.929728]  ? lockdep_hardirqs_on+0x3bb/0x5b0
+[  794.934292]  ? trace_hardirqs_on_caller+0x310/0x310
+[  794.939285]  ? zap_class+0x640/0x640
+[  794.943014]  ? lockdep_hardirqs_on+0x3bb/0x5b0
+[  794.947588]  ? lock_acquire+0x1ed/0x520
+[  794.951537]  ? worker_thread+0x3e0/0x1390
+[  794.955672]  ? kasan_check_read+0x11/0x20
+[  794.959797]  ? do_raw_spin_lock+0x14f/0x350
+[  794.964098]  ? kasan_check_read+0x11/0x20
+[  794.968223]  ? rwlock_bug.part.2+0x90/0x90
+[  794.972435]  ? trace_hardirqs_on+0x310/0x310
+[  794.976828]  worker_thread+0x17f/0x1390
+[  794.980779]  ? __switch_to_asm+0x34/0x70
+[  794.984825]  ? process_one_work+0x1c40/0x1c40
+[  794.989310]  ? __sched_text_start+0x8/0x8
+[  794.993446]  ? __kthread_parkme+0xce/0x1a0
+[  794.997655]  ? _raw_spin_unlock_irqrestore+0x82/0xd0
+[  795.002736]  ? _raw_spin_unlock_irqrestore+0x82/0xd0
+[  795.007814]  ? lockdep_hardirqs_on+0x3bb/0x5b0
+[  795.012390]  ? trace_hardirqs_on+0xbd/0x310
+[  795.016686]  ? kasan_check_read+0x11/0x20
+[  795.020810]  ? __kthread_parkme+0xce/0x1a0
+[  795.025036]  ? trace_hardirqs_off_caller+0x310/0x310
+[  795.030138]  ? _raw_spin_unlock_irqrestore+0x6d/0xd0
+[  795.035233]  ? __sanitizer_cov_trace_const_cmp8+0x18/0x20
+[  795.040742]  ? __kthread_parkme+0xfb/0x1a0
+[  795.044955]  ? process_one_work+0x1c40/0x1c40
+[  795.049426]  kthread+0x35a/0x440
+[  795.052772]  ? kthread_stop+0x900/0x900
+[  795.056725]  ret_from_fork+0x3a/0x50
+[  795.061996] Kernel Offset: disabled
+[  795.065886] Rebooting in 86400 seconds..