aboutsummaryrefslogtreecommitdiffstats
path: root/pkg
diff options
context:
space:
mode:
authorDmitry Vyukov <dvyukov@google.com>2024-05-31 16:11:05 +0200
committerDmitry Vyukov <dvyukov@google.com>2024-06-03 15:04:36 +0000
commit060bb1abe2d1541db9f1a47b8affdf219eb90b57 (patch)
tree4033e421bfd2e0a1f7bf358d848370f1a23dc3fb /pkg
parent3f2f4d56784c072cbe78677a3c17584723043a04 (diff)
pkg/fuzzer: update deflake comment
Update the comment based on our new understanding.
Diffstat (limited to 'pkg')
-rw-r--r--pkg/fuzzer/job.go10
1 files changed, 7 insertions, 3 deletions
diff --git a/pkg/fuzzer/job.go b/pkg/fuzzer/job.go
index 66013b0e2..505feb28c 100644
--- a/pkg/fuzzer/job.go
+++ b/pkg/fuzzer/job.go
@@ -156,9 +156,13 @@ func (job *triageJob) deflake(exec func(*queue.Request, ProgFlags) *queue.Result
info.rawCover = inf.Cover
}
newMaxSignal := cover.addRawMaxSignal(inf.Signal, prio)
- // Since signal may be flaky, update the new signal we are chasing.
- // It's possible that we won't get any of the orignal new signal,
- // but instead will get some other stable new signal.
+ // Since the signal is frequently flaky, we may get some new new max signal.
+ // Merge it into the new signal we are chasing.
+ // Most likely we won't conclude it's stable signal b/c we already have at least one
+ // initial run w/o this signal, so if we exit after 3 (needRuns) runs, it won't be stable.
+ // However, it's still possible if we do more than needRuns runs.
+ // But also we already observed it and we know it's flaky, so at least doing
+ // cover.addRawMaxSignal for it looks useful.
job.newSignal.Merge(newMaxSignal)
info.cover.Merge(inf.Cover)
for j := len(signals) - 1; j > 0; j-- {