aboutsummaryrefslogtreecommitdiffstats
path: root/pkg/vcs
diff options
context:
space:
mode:
authorTaras Madan <tarasmadan@google.com>2025-07-15 16:43:33 +0200
committerTaras Madan <tarasmadan@google.com>2025-07-17 08:31:25 +0000
commitabd11cfd08430ec5f9d2c6dbd0e0f798816922d1 (patch)
tree522a8cc072d07d85c8a1d37b5b3ab89483599b48 /pkg/vcs
parenta81f309b57265e5760b926274e1f1681e7550e41 (diff)
all: apply linter auto fixes
./tools/syz-env bin/golangci-lint run ./... --fix
Diffstat (limited to 'pkg/vcs')
-rw-r--r--pkg/vcs/linux.go12
1 files changed, 7 insertions, 5 deletions
diff --git a/pkg/vcs/linux.go b/pkg/vcs/linux.go
index e34fe9186..f1e73a265 100644
--- a/pkg/vcs/linux.go
+++ b/pkg/vcs/linux.go
@@ -50,7 +50,8 @@ func (ctx *linux) PreviousReleaseTags(commit, compilerType string) ([]string, er
}
cutoff := ""
- if compilerType == "gcc" {
+ switch compilerType {
+ case "gcc":
// Initially we tried to stop at 3.8 because:
// v3.8 does not work with modern perl, and as we go further in history
// make stops to work, then binutils, glibc, etc. So we stop at v3.8.
@@ -75,7 +76,7 @@ func (ctx *linux) PreviousReleaseTags(commit, compilerType string) ([]string, er
// This has caused lots of bad bisection results, see #3224. We either need a new
// universal image or a kernel version dependant image selection.
cutoff = "v4.18"
- } else if compilerType == "clang" {
+ case "clang":
// v5.3 was the first release with solid clang support, however I was able to
// compile v5.1..v5.3 using a newer defconfig + make oldconfig. Everything older
// would require further cherry-picks.
@@ -139,11 +140,12 @@ func (ctx *linux) EnvForCommit(
setLinuxTagConfigs(cf, tags)
compiler := ""
- if compilerType == "gcc" {
+ switch compilerType {
+ case "gcc":
compiler = linuxGCCPath(tags, binDir, defaultCompiler)
- } else if compilerType == "clang" {
+ case "clang":
compiler = linuxClangPath(tags, binDir, defaultCompiler)
- } else {
+ default:
return nil, fmt.Errorf("unsupported bisect compiler: %v", compilerType)
}