diff options
| author | Eng Zer Jun <engzerjun@gmail.com> | 2022-03-23 16:04:21 +0800 |
|---|---|---|
| committer | Aleksandr Nogikh <wp32pw@gmail.com> | 2022-03-28 12:03:24 +0200 |
| commit | 0d08379d0a6e5c91206a82e207c6c05f0f9fddc4 (patch) | |
| tree | 56b9d5c90b545c2d2e7bd74b059b1d1e2be50834 /pkg/vcs | |
| parent | 89bc860804252dbacb8c2bea60b9204859f4afd7 (diff) | |
all: use `t.TempDir` to create temporary test directory
This commit replaces all `ioutil.TempDir` with `t.TempDir` in tests.
The directory created by `t.TempDir` is automatically removed when the
test and all its subtests complete.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Diffstat (limited to 'pkg/vcs')
| -rw-r--r-- | pkg/vcs/git_repo_test.go | 19 |
1 files changed, 3 insertions, 16 deletions
diff --git a/pkg/vcs/git_repo_test.go b/pkg/vcs/git_repo_test.go index 41564fda6..adf222629 100644 --- a/pkg/vcs/git_repo_test.go +++ b/pkg/vcs/git_repo_test.go @@ -5,7 +5,6 @@ package vcs import ( "fmt" - "io/ioutil" "os" "path/filepath" "sort" @@ -22,11 +21,7 @@ func init() { func TestGitRepo(t *testing.T) { t.Parallel() - baseDir, err := ioutil.TempDir("", "syz-git-test") - if err != nil { - t.Fatal(err) - } - defer os.RemoveAll(baseDir) + baseDir := t.TempDir() repo1 := CreateTestRepo(t, baseDir, "repo1") repo2 := CreateTestRepo(t, baseDir, "repo2") repo := newGit(filepath.Join(baseDir, "repo"), nil, nil) @@ -140,11 +135,7 @@ func TestGitRepo(t *testing.T) { func TestMetadata(t *testing.T) { t.Parallel() - repoDir, err := ioutil.TempDir("", "syz-git-test") - if err != nil { - t.Fatal(err) - } - defer os.RemoveAll(repoDir) + repoDir := t.TempDir() repo := MakeTestRepo(t, repoDir) prevHash := "" for i, test := range metadataTests { @@ -329,11 +320,7 @@ Comment out an assertion that's now bogus and add a comment. func TestBisect(t *testing.T) { t.Parallel() - repoDir, err := ioutil.TempDir("", "syz-git-test") - if err != nil { - t.Fatal(err) - } - defer os.RemoveAll(repoDir) + repoDir := t.TempDir() repo := MakeTestRepo(t, repoDir) var commits []string for i := 0; i < 5; i++ { |