diff options
| author | Aleksandr Nogikh <nogikh@google.com> | 2023-06-15 15:38:51 +0200 |
|---|---|---|
| committer | Aleksandr Nogikh <nogikh@google.com> | 2023-07-05 11:29:44 +0000 |
| commit | e8b147c6e77e4568d3e7df74121a28e95ee8440a (patch) | |
| tree | 45e8e43e65a1ccb29d9eba5b68cd45965565afde /pkg/vcs/vcs.go | |
| parent | 9a3d2957802872770199d00684132907508a6915 (diff) | |
pkg/bisect: try to drop instrumentation
Refactor Minimize().
As a part of Minimize(), attempt to drop all unnecessary instrumentation
and test whether the kernel is still crashing.
This should reduce the number of irrelevant crashes during bisection and
thus increase bisection result quality.
Diffstat (limited to 'pkg/vcs/vcs.go')
| -rw-r--r-- | pkg/vcs/vcs.go | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/pkg/vcs/vcs.go b/pkg/vcs/vcs.go index 3e57a1695..9515692ea 100644 --- a/pkg/vcs/vcs.go +++ b/pkg/vcs/vcs.go @@ -16,6 +16,7 @@ import ( "github.com/google/syzkaller/dashboard/dashapi" "github.com/google/syzkaller/pkg/debugtracer" "github.com/google/syzkaller/pkg/osutil" + "github.com/google/syzkaller/pkg/report/crash" "github.com/google/syzkaller/sys/targets" ) @@ -96,8 +97,8 @@ type Bisecter interface { } type ConfigMinimizer interface { - Minimize(target *targets.Target, original, baseline []byte, dt debugtracer.DebugTracer, - pred func(test []byte) (BisectResult, error)) ([]byte, error) + Minimize(target *targets.Target, original, baseline []byte, types []crash.Type, + dt debugtracer.DebugTracer, pred func(test []byte) (BisectResult, error)) ([]byte, error) } type Commit struct { |