diff options
| author | Taras Madan <tarasmadan@google.com> | 2024-09-16 14:29:26 +0200 |
|---|---|---|
| committer | Taras Madan <tarasmadan@google.com> | 2024-09-30 10:00:18 +0000 |
| commit | 179f40292f64debb6b3ea2fe5e950f62f5a05a18 (patch) | |
| tree | 664326084a8dee3bbe8847cf8196fd0b9417dee4 /pkg/validator/validator_test.go | |
| parent | ba29ff75d05fca62258d71ffc063e70f0d7b8b09 (diff) | |
pkg/validator: target value is not empty by default
The consistency make the code more predictable.
We want all the values to be non-empty.
If "empty" is an option - use validator.AnyOk(validator.EmptyStr(target), otherCheck(target)).
Diffstat (limited to 'pkg/validator/validator_test.go')
| -rw-r--r-- | pkg/validator/validator_test.go | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/pkg/validator/validator_test.go b/pkg/validator/validator_test.go index ef04d9cde..6397081e4 100644 --- a/pkg/validator/validator_test.go +++ b/pkg/validator/validator_test.go @@ -24,6 +24,7 @@ func TestIsCommitHash(t *testing.T) { validator.CommitHash("!311c1b497e51a628aa89e7cb954481e5f9dced2", "valName").Err.Error()) } +// nolint: dupl func TestIsNamespaceName(t *testing.T) { assert.True(t, validator.NamespaceName("upstream").Ok) assert.False(t, validator.NamespaceName("up").Ok) @@ -58,6 +59,7 @@ func TestIsDashboardClientKey(t *testing.T) { func TestIsKernelFilePath(t *testing.T) { assert.True(t, validator.KernelFilePath("io_uring/advise.c").Ok) assert.False(t, validator.KernelFilePath("io-uring/advise.c").Ok) + assert.False(t, validator.KernelFilePath("").Ok) assert.Equal(t, "not a kernel file path", validator.KernelFilePath("io-uring").Err.Error()) assert.Equal(t, "kernelPath: not a kernel file path", |