aboutsummaryrefslogtreecommitdiffstats
path: root/pkg/subsystem
diff options
context:
space:
mode:
authorAleksandr Nogikh <nogikh@google.com>2023-04-11 11:05:18 +0200
committerAleksandr Nogikh <wp32pw@gmail.com>2023-04-13 13:39:53 +0200
commit3cfcaa1bed770dce1e4d55a41c168a9a56f931a5 (patch)
treed62e3c6e4a94fb8b8a69ad76b574f6777099c894 /pkg/subsystem
parent82d5e53ec0af57823952183e2e2603ce2462fb66 (diff)
pkg/subsystem: optionally disable monthly reports
For some subsystems (e.g. `kernel`) such reports just don't make much sense, since there are too many incorrectly classified bugs in there. Make it possible to exclude such subsystems from periodic reminders.
Diffstat (limited to 'pkg/subsystem')
-rw-r--r--pkg/subsystem/entities.go2
-rw-r--r--pkg/subsystem/linux/rules.go7
-rw-r--r--pkg/subsystem/linux/subsystems.go1
-rw-r--r--pkg/subsystem/lists/linux.go1
4 files changed, 11 insertions, 0 deletions
diff --git a/pkg/subsystem/entities.go b/pkg/subsystem/entities.go
index 457e57a3e..338447ad4 100644
--- a/pkg/subsystem/entities.go
+++ b/pkg/subsystem/entities.go
@@ -10,6 +10,8 @@ type Subsystem struct {
Lists []string
Maintainers []string
Parents []*Subsystem
+ // If NoReminders is set to true, there should be no monthly reports for the subsystem.
+ NoReminders bool
}
// ReachableParents returns the set of subsystems reachable from the current one.
diff --git a/pkg/subsystem/linux/rules.go b/pkg/subsystem/linux/rules.go
index 3f2149af2..d44451692 100644
--- a/pkg/subsystem/linux/rules.go
+++ b/pkg/subsystem/linux/rules.go
@@ -12,6 +12,8 @@ type customRules struct {
// These subsystems need to be extracted even without mailing lists.
// Key is the subsystem name, value is the list of raw names in MAINTAINERS.
extraSubsystems map[string][]string
+ // For these subsystems we do not generate monthly reminders.
+ noReminders map[string]struct{}
}
var (
@@ -88,5 +90,10 @@ var (
"kernfs": {"KERNFS"},
"udf": {"UDF FILESYSTEM"},
},
+ noReminders: map[string]struct{}{
+ // Many misclassified bugs end up in `kernel`, so there's no sense
+ // in generating monthly reports for it.
+ "kernel": {},
+ },
}
)
diff --git a/pkg/subsystem/linux/subsystems.go b/pkg/subsystem/linux/subsystems.go
index 880b1fcaf..1d1d84ed2 100644
--- a/pkg/subsystem/linux/subsystems.go
+++ b/pkg/subsystem/linux/subsystems.go
@@ -130,6 +130,7 @@ func (ctx *linuxCtx) applyExtraRules(list []*subsystem.Subsystem) {
}
for _, entry := range list {
entry.Syscalls = ctx.extraRules.subsystemCalls[entry.Name]
+ _, entry.NoReminders = ctx.extraRules.noReminders[entry.Name]
}
}
diff --git a/pkg/subsystem/lists/linux.go b/pkg/subsystem/lists/linux.go
index c097c16ca..7716b0c20 100644
--- a/pkg/subsystem/lists/linux.go
+++ b/pkg/subsystem/lists/linux.go
@@ -2149,6 +2149,7 @@ func subsystems_linux() []*Subsystem {
{IncludeRegexp: "^net/vmw_vsock/vmci_transport[^/]*$"},
{IncludeRegexp: "axp[128]"},
},
+ NoReminders: true,
}
kernfs = Subsystem{