aboutsummaryrefslogtreecommitdiffstats
path: root/pkg/rpcserver
diff options
context:
space:
mode:
authorDmitry Vyukov <dvyukov@google.com>2024-06-27 12:01:58 +0200
committerDmitry Vyukov <dvyukov@google.com>2024-07-02 15:07:08 +0000
commit07dedd50ee8834dbca4da7667e69e72b7d0565b9 (patch)
tree44925ee15f9fad9ad0641435fd459d25375c811d /pkg/rpcserver
parent6a2ff1acbd95b320444a729d9d281835be88ec66 (diff)
pkg/fuzzer: remove signal rotation
Signal rotation is intended to make the fuzzer re-discover flaky coverage in non flaky way. However, taking into accout that we get effectively the same effect after each manager restart, and that the fuzzer is overloaded with triage/smash jobs, it does not look to be worth it.
Diffstat (limited to 'pkg/rpcserver')
-rw-r--r--pkg/rpcserver/rpcserver.go7
-rw-r--r--pkg/rpcserver/runner.go5
2 files changed, 5 insertions, 7 deletions
diff --git a/pkg/rpcserver/rpcserver.go b/pkg/rpcserver/rpcserver.go
index 58ef2d363..40ca9a316 100644
--- a/pkg/rpcserver/rpcserver.go
+++ b/pkg/rpcserver/rpcserver.go
@@ -344,7 +344,7 @@ func (serv *Server) connectionLoop(runner *Runner) error {
// buffer too much (we don't want to grow it larger than what will be needed
// to send programs).
n := min(len(maxSignal), 50000)
- if err := runner.sendSignalUpdate(maxSignal[:n], nil); err != nil {
+ if err := runner.sendSignalUpdate(maxSignal[:n]); err != nil {
return err
}
maxSignal = maxSignal[n:]
@@ -489,11 +489,10 @@ func (serv *Server) ShutdownInstance(name string, crashed bool) ([]ExecRecord, [
return runner.shutdown(crashed)
}
-func (serv *Server) DistributeSignalDelta(plus, minus signal.Signal) {
+func (serv *Server) DistributeSignalDelta(plus signal.Signal) {
plusRaw := plus.ToRaw()
- minusRaw := minus.ToRaw()
serv.foreachRunnerAsync(func(runner *Runner) {
- runner.sendSignalUpdate(plusRaw, minusRaw)
+ runner.sendSignalUpdate(plusRaw)
})
}
diff --git a/pkg/rpcserver/runner.go b/pkg/rpcserver/runner.go
index b5903848f..219ef2c35 100644
--- a/pkg/rpcserver/runner.go
+++ b/pkg/rpcserver/runner.go
@@ -311,13 +311,12 @@ func (runner *Runner) convertCallInfo(call *flatrpc.CallInfo) {
}
}
-func (runner *Runner) sendSignalUpdate(plus, minus []uint64) error {
+func (runner *Runner) sendSignalUpdate(plus []uint64) error {
msg := &flatrpc.HostMessage{
Msg: &flatrpc.HostMessages{
Type: flatrpc.HostMessagesRawSignalUpdate,
Value: &flatrpc.SignalUpdate{
- NewMax: runner.canonicalizer.Decanonicalize(plus),
- DropMax: runner.canonicalizer.Decanonicalize(minus),
+ NewMax: runner.canonicalizer.Decanonicalize(plus),
},
},
}