all: add a DumpMemory feature

On Linux, verify that makedumpfile and the second kernel are present,
then set up a kernel to be used on panic.

2 files changed, 18 insertions, 0 deletions

diff --git a/pkg/rpcserver/rpcserver.go b/pkg/rpcserver/rpcserver.go
index 04c5d877f..385c0350d 100644
--- a/pkg/rpcserver/rpcserver.go
+++ b/pkg/rpcserver/rpcserver.go
@@ -162,6 +162,9 @@ func New(cfg *RemoteConfig) (Server, error) {
 	if !cfg.Experimental.RemoteCover {
 		features &= ^flatrpc.FeatureExtraCoverage
 	}
+	if !cfg.MemoryDump {
+		features &= ^flatrpc.FeatureMemoryDump
+	}
 	return newImpl(&Config{
 		Config: vminfo.Config{
 			Target:     cfg.Target,
@@ -170,6 +173,7 @@ func New(cfg *RemoteConfig) (Server, error) {
 			Syscalls:   cfg.Syscalls,
 			Debug:      cfg.Debug,
 			Cover:      cfg.Cover,
+			MemoryDump: cfg.MemoryDump,
 			Sandbox:    sandbox,
 			SandboxArg: cfg.SandboxArg,
 		},
diff --git a/pkg/rpcserver/rpcserver_test.go b/pkg/rpcserver/rpcserver_test.go
index 429b275ac..86dddcf76 100644
--- a/pkg/rpcserver/rpcserver_test.go
+++ b/pkg/rpcserver/rpcserver_test.go
@@ -72,6 +72,20 @@ func TestNew(t *testing.T) {
 			},
 			expectedServCheck: func(srv Server) {
 				s := srv.(*server)
+				assert.Equal(t, s.cfg.Config.Features,
+					flatrpc.AllFeatures&(^flatrpc.FeatureExtraCoverage)&(^flatrpc.FeatureMemoryDump))
+				assert.Nil(t, s.serv)
+			},
+		},
+		{
+			name: "memory dump enabled",
+			modifyCfg: func() *mgrconfig.Config {
+				cfg := defaultCfg
+				cfg.MemoryDump = true
+				return &cfg
+			},
+			expectedServCheck: func(srv Server) {
+				s := srv.(*server)
 				assert.Equal(t, s.cfg.Config.Features, flatrpc.AllFeatures&(^flatrpc.FeatureExtraCoverage))
 				assert.Nil(t, s.serv)
 			},