diff options
| author | Dmitry Vyukov <dvyukov@google.com> | 2017-11-29 17:53:07 +0100 |
|---|---|---|
| committer | Dmitry Vyukov <dvyukov@google.com> | 2017-11-29 18:24:30 +0100 |
| commit | 29b0fd90e6ac720fb21cc98ae89acfa6704b35bc (patch) | |
| tree | 7f1bdb6c9a3d04b426bdfeec8a45ee032b6cba9a /pkg/repro | |
| parent | 46c864566a5ce47fade185c639c9df7d9234380b (diff) | |
pkg/report: include Maintainers into report
Currently getting a complete report requires a complex,
multi-step dance (including getting information that
external users are not interested in -- guilty file).
Simplify interface down to 2 functions: Parse and Symbolize.
Parse does what it did before, Symbolize symbolizes report
and fills in maintainers. This simplifies both implementations
of Reporter interface and all users of the interface.
Potentially we could get this down to 1 function Parse
that does everything. However, (1) Symbolize can fail,
while Parse cannot, (2) usually we want to ignore (log)
Symbolize errors, but otherwise proceed with the report,
(3) repro does not need symbolization for all but the
last report.
Diffstat (limited to 'pkg/repro')
| -rw-r--r-- | pkg/repro/repro.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/pkg/repro/repro.go b/pkg/repro/repro.go index 1d9b51493..29ede6fd4 100644 --- a/pkg/repro/repro.go +++ b/pkg/repro/repro.go @@ -35,7 +35,7 @@ type Result struct { Opts csource.Options CRepro bool Stats Stats - // Information about the final crash that we reproduced. + // Information about the final (non-symbolized) crash that we reproduced. // Can be different from what we started reproducing. Report *report.Report } |