diff options
| author | Aleksandr Nogikh <nogikh@google.com> | 2021-08-02 17:08:58 +0000 |
|---|---|---|
| committer | Aleksandr Nogikh <wp32pw@gmail.com> | 2021-08-06 15:34:58 +0200 |
| commit | de040344f89656862b5bbd306b8a9c143dae3dea (patch) | |
| tree | 41bf6feec26d42e6ec18ce7d55e6a2b1f0bbc1d9 /pkg/report/linux.go | |
| parent | 00fc459663540df701f62355dc1871a583021aa7 (diff) | |
pkg/report: separate reporter wrapper from OS-specific implementations
Currently a number of report post-processing activities are implemented as a
decorator over the interface that defines OS-specific implementations.
Following exactly the same interface is too restrictive in this case as adding
extra parameters to the post-processing forces the developer to adjust all
implementations thay may not need these parameters at all.
Untie the wrapper from the Reporter interface. Use a package-private
reporterImpl interface for the OS-specific implementations, while having an
exported Reporter structure. Make sure that Reporter is stored and
passed as a pointer.
Diffstat (limited to 'pkg/report/linux.go')
| -rw-r--r-- | pkg/report/linux.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/pkg/report/linux.go b/pkg/report/linux.go index 16ca3c56d..6955a6057 100644 --- a/pkg/report/linux.go +++ b/pkg/report/linux.go @@ -33,7 +33,7 @@ type linux struct { eoi []byte } -func ctorLinux(cfg *config) (Reporter, []string, error) { +func ctorLinux(cfg *config) (reporterImpl, []string, error) { var symbols map[string][]symbolizer.Symbol vmlinux := "" if cfg.kernelObj != "" { |