aboutsummaryrefslogtreecommitdiffstats
path: root/pkg/report/linux.go
diff options
context:
space:
mode:
authorTaras Madan <tarasmadan@google.com>2025-06-20 12:04:24 +0200
committerTaras Madan <tarasmadan@google.com>2025-06-20 13:09:54 +0000
commitd6cdfb8a765c64793bc63cf630e68fbdd0ee0974 (patch)
tree4ee8ffc152e02bf821671ce02cd28015aa4aa77c /pkg/report/linux.go
parente3003213f6deee7f817122847d77b769bc8b46ad (diff)
pkg/report: minor refactoring
setExecutorInfo is closer to Report. Distinguish reportType and defaultReportType Make setter a Report member function.
Diffstat (limited to 'pkg/report/linux.go')
-rw-r--r--pkg/report/linux.go10
1 files changed, 5 insertions, 5 deletions
diff --git a/pkg/report/linux.go b/pkg/report/linux.go
index 782cb9032..3d03671bd 100644
--- a/pkg/report/linux.go
+++ b/pkg/report/linux.go
@@ -188,10 +188,10 @@ func (ctx *linux) Parse(output []byte) *Report {
}
rep.reportPrefixLen = len(rep.Report)
rep.Report = append(rep.Report, report...)
- setReportType(rep, oops, format)
- ctx.setExecutorInfo(rep)
+ rep.setType(format.reportType, oops.defaultReportType)
+ setExecutorInfo(rep)
if !rep.Corrupted {
- rep.Corrupted, rep.CorruptedReason = ctx.isCorrupted(title, report, format)
+ rep.Corrupted, rep.CorruptedReason = isCorrupted(title, report, format)
}
if rep.CorruptedReason == corruptedNoFrames && context != contextConsole && !questionable {
// We used to look at questionable frame with the following incentive:
@@ -898,7 +898,7 @@ func getMaintainersImpl(kernelSrc, file string, blame bool) (vcs.Recipients, err
return vcs.ParseMaintainersLinux(output), nil
}
-func (ctx *linux) isCorrupted(title string, report []byte, format oopsFormat) (bool, string) {
+func isCorrupted(title string, report []byte, format oopsFormat) (bool, string) {
// Check for common title corruptions.
for _, re := range linuxCorruptedTitles {
if re.MatchString(title) {
@@ -954,7 +954,7 @@ func (ctx *linux) isCorrupted(title string, report []byte, format oopsFormat) (b
var syzLinuxCommRe = regexp.MustCompile(` Comm: syz\.(\d+)\.(\d+) `)
-func (ctx *linux) setExecutorInfo(rep *Report) {
+func setExecutorInfo(rep *Report) {
match := syzLinuxCommRe.FindSubmatch(rep.Report)
if match == nil {
return