diff options
| author | Eng Zer Jun <engzerjun@gmail.com> | 2022-03-23 16:04:21 +0800 |
|---|---|---|
| committer | Aleksandr Nogikh <wp32pw@gmail.com> | 2022-03-28 12:03:24 +0200 |
| commit | 0d08379d0a6e5c91206a82e207c6c05f0f9fddc4 (patch) | |
| tree | 56b9d5c90b545c2d2e7bd74b059b1d1e2be50834 /pkg/osutil | |
| parent | 89bc860804252dbacb8c2bea60b9204859f4afd7 (diff) | |
all: use `t.TempDir` to create temporary test directory
This commit replaces all `ioutil.TempDir` with `t.TempDir` in tests.
The directory created by `t.TempDir` is automatically removed when the
test and all its subtests complete.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Diffstat (limited to 'pkg/osutil')
| -rw-r--r-- | pkg/osutil/fileutil_test.go | 8 | ||||
| -rw-r--r-- | pkg/osutil/osutil_test.go | 7 |
2 files changed, 2 insertions, 13 deletions
diff --git a/pkg/osutil/fileutil_test.go b/pkg/osutil/fileutil_test.go index 62e07bc8f..20d02ea22 100644 --- a/pkg/osutil/fileutil_test.go +++ b/pkg/osutil/fileutil_test.go @@ -5,8 +5,6 @@ package osutil import ( "fmt" - "io/ioutil" - "os" "path/filepath" "strconv" "sync" @@ -16,11 +14,7 @@ import ( func TestProcessTempDir(t *testing.T) { for try := 0; try < 10; try++ { func() { - tmp, err := ioutil.TempDir("", "syz") - if err != nil { - t.Fatalf("failed to create a temp dir: %v", err) - } - defer os.RemoveAll(tmp) + tmp := t.TempDir() const P = 16 // Pre-create half of the instances with stale pid. var dirs []string diff --git a/pkg/osutil/osutil_test.go b/pkg/osutil/osutil_test.go index 168e7ba36..713a62c14 100644 --- a/pkg/osutil/osutil_test.go +++ b/pkg/osutil/osutil_test.go @@ -5,7 +5,6 @@ package osutil import ( "fmt" - "io/ioutil" "os" "path/filepath" "strings" @@ -81,11 +80,7 @@ func TestCopyFiles(t *testing.T) { t.Run(fnName, func(t *testing.T) { for i, test := range tests { t.Run(fmt.Sprint(i), func(t *testing.T) { - dir, err := ioutil.TempDir("", "syz-osutil-test") - if err != nil { - t.Fatal(err) - } - defer os.RemoveAll(dir) + dir := t.TempDir() src := filepath.Join(dir, "src") dst := filepath.Join(dir, "dst") for _, file := range test.files { |