diff options
| author | Aleksandr Nogikh <nogikh@google.com> | 2025-04-11 14:36:33 +0200 |
|---|---|---|
| committer | Aleksandr Nogikh <nogikh@google.com> | 2025-04-15 08:18:26 +0000 |
| commit | 1c80ed9aeb36281de48d65ebde17fd5ed8494d33 (patch) | |
| tree | 197a82767d564226d868992e2354fd81f64f5d68 /pkg/manager/diff.go | |
| parent | df98310f5ee6c72303eacdd6df1f30dd644bcaba (diff) | |
pkg/manager: disable fault injection during diff fuzzing
It may be introducing false positives into the process of determining
whether the bug affects the base kernel.
Let's stay on the safe side and not do it for now.
Diffstat (limited to 'pkg/manager/diff.go')
| -rw-r--r-- | pkg/manager/diff.go | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/pkg/manager/diff.go b/pkg/manager/diff.go index 229868ff9..781ac0152 100644 --- a/pkg/manager/diff.go +++ b/pkg/manager/diff.go @@ -416,9 +416,8 @@ func (kc *kernelContext) setupFuzzer(features flatrpc.Feature, syscalls map[*pro fuzzerObj := fuzzer.NewFuzzer(kc.ctx, &fuzzer.Config{ Corpus: corpusObj, Coverage: kc.cfg.Cover, - // TODO: it may be unstable between different revisions though. - // For now it's only kept true because it seems to increase repro chances in local runs (???). - FaultInjection: true, + // Fault injection may bring instaibility into bug reproducibility, which may lead to false positives. + FaultInjection: false, Comparisons: features&flatrpc.FeatureComparisons != 0, Collide: true, EnabledCalls: syscalls, |