aboutsummaryrefslogtreecommitdiffstats
path: root/pkg/kernel
diff options
context:
space:
mode:
authorDmitry Vyukov <dvyukov@google.com>2018-05-14 11:17:23 +0200
committerDmitry Vyukov <dvyukov@google.com>2018-05-14 11:17:23 +0200
commit2a287a4dfc36295e1a2f0fa1e8c6c061442dc4f5 (patch)
tree5b1e5cd360f7ae80971e95267662bdee2aa3c1c7 /pkg/kernel
parent1944eeb95d5110c47610fbed04cd5fc5fd9c6c3a (diff)
pkg/kernel: accept kernel config as byte slice
We usually have the config in memory, so saving it to disk is an unnecessary step. Accept byte slice directly. Update #501
Diffstat (limited to 'pkg/kernel')
-rw-r--r--pkg/kernel/kernel.go5
1 files changed, 3 insertions, 2 deletions
diff --git a/pkg/kernel/kernel.go b/pkg/kernel/kernel.go
index 3cd689d70..a51da8db3 100644
--- a/pkg/kernel/kernel.go
+++ b/pkg/kernel/kernel.go
@@ -24,9 +24,9 @@ import (
"github.com/google/syzkaller/pkg/osutil"
)
-func Build(dir, compiler, config string) error {
+func Build(dir, compiler string, config []byte) error {
configFile := filepath.Join(dir, ".config")
- if err := osutil.CopyFile(config, configFile); err != nil {
+ if err := osutil.WriteFile(configFile, config); err != nil {
return fmt.Errorf("failed to write config file: %v", err)
}
if err := osutil.SandboxChown(configFile); err != nil {
@@ -89,6 +89,7 @@ func CreateImage(kernelDir, userspaceDir, cmdlineFile, sysctlFile, image, sshkey
if _, err = osutil.Run(time.Hour, cmd); err != nil {
return fmt.Errorf("image build failed: %v", err)
}
+ // Note: we use CopyFile instead of Rename because src and dst can be on different filesystems.
if err := osutil.CopyFile(filepath.Join(tempDir, "disk.raw"), image); err != nil {
return err
}