diff options
| author | Dmitry Vyukov <dvyukov@google.com> | 2018-04-06 21:24:22 +0200 |
|---|---|---|
| committer | Dmitry Vyukov <dvyukov@google.com> | 2018-04-06 21:24:22 +0200 |
| commit | d613535f944822fb93ba6b033f22ede8628275f5 (patch) | |
| tree | 266c25a9099c7d3f3407a7a5cfe338898feafd1f /pkg/ipc | |
| parent | 53196ce262345e7c9895a174296e8896271cc75e (diff) | |
pkg/ipc: disable coverage collection by default
syz-manager always passes explicit value for the flag.
syz-stress does not need coverage.
The only real user is syz-execprog. syz-execprog already
forces coverage with -coverfile is given. Coverage is harmful
for external users trying to reproduce reported bugs.
For the remaining cases of syzkaller developers running
syz-execprog on KCOV-enabled kernel, the flag can be given
manually if really needed.
Fixes #554
Diffstat (limited to 'pkg/ipc')
| -rw-r--r-- | pkg/ipc/ipc.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/pkg/ipc/ipc.go b/pkg/ipc/ipc.go index 104be74d2..320352a84 100644 --- a/pkg/ipc/ipc.go +++ b/pkg/ipc/ipc.go @@ -63,7 +63,7 @@ var ( flagExecutor = flag.String("executor", "./syz-executor", "path to executor binary") flagThreaded = flag.Bool("threaded", true, "use threaded mode in executor") flagCollide = flag.Bool("collide", true, "collide syscalls to provoke data races") - flagSignal = flag.Bool("cover", true, "collect feedback signals (coverage)") + flagSignal = flag.Bool("cover", false, "collect feedback signals (coverage)") flagSandbox = flag.String("sandbox", "none", "sandbox for fuzzing (none/setuid/namespace)") flagDebug = flag.Bool("debug", false, "debug output from executor") flagTimeout = flag.Duration("timeout", 0, "execution timeout") |