diff options
| author | Aleksandr Nogikh <nogikh@google.com> | 2022-04-19 08:56:14 +0000 |
|---|---|---|
| committer | Aleksandr Nogikh <wp32pw@gmail.com> | 2022-04-19 12:06:44 +0200 |
| commit | b5866354b986ff8955bba8e66a4a6aa42a279af0 (patch) | |
| tree | 7d4b8b6520406f27dd7cc2f0be347bd6fd0b3939 /pkg/instance/instance.go | |
| parent | 8bcc32a67bc7180173447e1a78c03dae096b4231 (diff) | |
all: fix patch testing for bugs witout C repro
Syzbot tests patches with -collide=true in order to trigger more bugs,
but now that -collide flag is deprecated, this no longer makes sense.
Moreover, it actually prevents the testing of bugs with syz repro now -
syz-execprog immediately exits due to -collide=true and env.Test()
accepts it as a normal outcome.
Set -collide=true only for those bugs, where collide was set to true by
the reproducer (and therefore syzkaller at that revision supported it).
Don't exit from syz-execprog immediately if -collide is set to true.
This will prevent such bugs from happening later and make the problem
more visible.
This was initially part of #3083, but seems to be more urgent to merge,
so pushing it as a separate PR.
Diffstat (limited to 'pkg/instance/instance.go')
| -rw-r--r-- | pkg/instance/instance.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/pkg/instance/instance.go b/pkg/instance/instance.go index e670a2c64..a3a87d338 100644 --- a/pkg/instance/instance.go +++ b/pkg/instance/instance.go @@ -398,7 +398,7 @@ func (inst *inst) testRepro() error { opts.FaultCall = -1 } cmdSyz := ExecprogCmd(execprogBin, executorBin, cfg.TargetOS, cfg.TargetArch, opts.Sandbox, - true, true, true, cfg.Procs, opts.FaultCall, opts.FaultNth, inst.optionalFlags, + true, true, opts.Collide, cfg.Procs, opts.FaultCall, opts.FaultNth, inst.optionalFlags, cfg.Timeouts.Slowdown, vmProgFile) if err := inst.testProgram(cmdSyz, cfg.Timeouts.NoOutputRunningTime); err != nil { return err |