diff options
| author | Taras Madan <tarasmadan@google.com> | 2023-07-21 11:51:35 +0200 |
|---|---|---|
| committer | Taras Madan <tarasmadan@google.com> | 2023-07-24 09:12:13 +0000 |
| commit | a36fe24b8383f6cd9b3519cd3eabdb9675d8992d (patch) | |
| tree | 3fef9a57760ccc4013289acd60e94e083db466e6 /pkg/ifuzz/x86 | |
| parent | 7549a7e1b57831cf6b08ce4700fc6e53417919f9 (diff) | |
all: use errors.As instead of .(type)
Diffstat (limited to 'pkg/ifuzz/x86')
| -rw-r--r-- | pkg/ifuzz/x86/gen/gen.go | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/pkg/ifuzz/x86/gen/gen.go b/pkg/ifuzz/x86/gen/gen.go index aae7429c0..01ba8420b 100644 --- a/pkg/ifuzz/x86/gen/gen.go +++ b/pkg/ifuzz/x86/gen/gen.go @@ -7,6 +7,7 @@ package main import ( "bufio" + "errors" "fmt" "os" "reflect" @@ -19,7 +20,7 @@ import ( "github.com/google/syzkaller/pkg/tool" ) -// nolint: gocyclo, gocognit, funlen +// nolint: gocyclo, gocognit, funlen, dupl func main() { if len(os.Args) != 2 { tool.Failf("usage: gen instructions.txt") @@ -113,8 +114,9 @@ func main() { insn1 = new(x86.Insn) *insn1 = *insn if err := parsePattern(insn1, vals); err != nil { - if _, ok := err.(errSkip); !ok { - reportError(err.Error()) + var errSkip errSkip + if !errors.As(err, &errSkip) { + reportError(errSkip.Error()) } if err.Error() != "" { fmt.Fprintf(os.Stderr, "skipping %v on line %v (%v)\n", insn.Name, i, err) @@ -127,8 +129,9 @@ func main() { break } if err := parseOperands(insn1, vals); err != nil { - if _, ok := err.(errSkip); !ok { - reportError(err.Error()) + var errSkip errSkip + if !errors.As(err, &errSkip) { + reportError(errSkip.Error()) } if err.Error() != "" { fmt.Fprintf(os.Stderr, "skipping %v on line %v (%v)\n", insn.Name, i, err) |