all: use consistent file permissions

Currently we have unix permissions for new files/dirs
hardcoded throughout the code base. Some places use 0644,
some - 0640, some - 0600 and a variety of other constants.

Introduce osutil.MkdirAll/WriteFile that use the default
permissions and use them throughout the code base.

This makes permissions consistent and also allows to easily
change the permissions later if we change our minds.

Also merge pkg/fileutil into pkg/osutil as they become
dependent on each other. The line between them was poorly
defined anyway as both operate on files.

1 files changed, 0 insertions, 65 deletions

diff --git a/pkg/fileutil/fileutil_test.go b/pkg/fileutil/fileutil_test.go
deleted file mode 100644
index d432ef5e7..000000000
--- a/pkg/fileutil/fileutil_test.go
+++ /dev/null
@@ -1,65 +0,0 @@
-// Copyright 2015 syzkaller project authors. All rights reserved.
-// Use of this source code is governed by Apache 2 LICENSE that can be found in the LICENSE file.
-
-package fileutil
-
-import (
-	"io/ioutil"
-	"os"
-	"path/filepath"
-	"strconv"
-	"sync"
-	"testing"
-)
-
-func TestProcessTempDir(t *testing.T) {
-	for try := 0; try < 10; try++ {
-		func() {
-			tmp, err := ioutil.TempDir("", "syz")
-			if err != nil {
-				t.Fatalf("failed to create a temp dir: %v", err)
-			}
-			defer os.RemoveAll(tmp)
-			const P = 16
-			// Pre-create half of the instances with stale pid.
-			var dirs []string
-			for i := 0; i < P/2; i++ {
-				dir, err := ProcessTempDir(tmp)
-				if err != nil {
-					t.Fatalf("failed to create process temp dir")
-				}
-				dirs = append(dirs, dir)
-			}
-			for _, dir := range dirs {
-				if err := ioutil.WriteFile(filepath.Join(dir, ".pid"), []byte(strconv.Itoa(999999999)), 0600); err != nil {
-					t.Fatalf("failed to write pid file: %v", err)
-				}
-			}
-			// Now request a bunch of instances concurrently.
-			done := make(chan bool)
-			allDirs := make(map[string]bool)
-			var mu sync.Mutex
-			for p := 0; p < P; p++ {
-				go func() {
-					defer func() {
-						done <- true
-					}()
-					dir, err := ProcessTempDir(tmp)
-					if err != nil {
-						t.Fatalf("failed to create process temp dir")
-					}
-					mu.Lock()
-					present := allDirs[dir]
-					allDirs[dir] = true
-					mu.Unlock()
-					if present {
-						t.Fatalf("duplicate dir %v", dir)
-					}
-				}()
-			}
-			for p := 0; p < P; p++ {
-				<-done
-			}
-		}()
-	}
-}