aboutsummaryrefslogtreecommitdiffstats
path: root/pkg/db
diff options
context:
space:
mode:
authorDmitry Vyukov <dvyukov@google.com>2018-08-01 13:19:54 +0200
committerDmitry Vyukov <dvyukov@google.com>2018-08-02 16:57:31 +0200
commitc67a9331a4f7c25df943ff821c9c6ed8013df869 (patch)
treee380eb862ba4e10896ad0d31442bd2f2c4928c0e /pkg/db
parent0a7cf4ec6374315af969a5bad7532095a1962492 (diff)
gometalinter: clean up some errcheck warnings
Check some errors where relevant. Unfortunately enabling errcheck does not look feasible, too many warnings. Update #538
Diffstat (limited to 'pkg/db')
-rw-r--r--pkg/db/db.go8
1 files changed, 4 insertions, 4 deletions
diff --git a/pkg/db/db.go b/pkg/db/db.go
index 4d48e1229..5c2755860 100644
--- a/pkg/db/db.go
+++ b/pkg/db/db.go
@@ -47,7 +47,9 @@ func Open(filename string) (*DB, error) {
db.Version, db.Records, db.uncompacted = deserializeDB(bufio.NewReader(f))
f.Close()
if len(db.Records) == 0 || db.uncompacted/10*9 > len(db.Records) {
- db.compact()
+ if err := db.compact(); err != nil {
+ return nil, err
+ }
}
return db, nil
}
@@ -75,8 +77,7 @@ func (db *DB) Delete(key string) {
func (db *DB) Flush() error {
if db.uncompacted/10*9 > len(db.Records) {
- db.compact()
- return nil
+ return db.compact()
}
if db.pending == nil {
return nil
@@ -168,7 +169,6 @@ func serializeRecord(w *bytes.Buffer, key string, val []byte, seq uint64) {
if _, err := fw.Write(val); err != nil {
panic(err)
}
- fw.Flush()
fw.Close()
binary.Write(bytes.NewBuffer(w.Bytes()[lenPos:lenPos:lenPos+8]), binary.LittleEndian, uint32(len(w.Bytes())-startPos))
}