.golangci.yml: make goconst checker more strict

1 files changed, 10 insertions, 6 deletions

diff --git a/pkg/csource/options.go b/pkg/csource/options.go
index 01389240c..b8fb804fb 100644
--- a/pkg/csource/options.go
+++ b/pkg/csource/options.go
@@ -260,21 +260,25 @@ func defaultFeatures(value bool) Features {
 }
 
 func ParseFeaturesFlags(enable string, disable string, defaultValue bool) (Features, error) {
-	if enable == "none" && disable == "none" {
+	const (
+		none = "none"
+		all  = "all"
+	)
+	if enable == none && disable == none {
 		return defaultFeatures(defaultValue), nil
 	}
-	if enable != "none" && disable != "none" {
+	if enable != none && disable != none {
 		return nil, fmt.Errorf("can't use -enable and -disable flags at the same time")
 	}
-	if enable == "all" || disable == "" {
+	if enable == all || disable == "" {
 		return defaultFeatures(true), nil
 	}
-	if disable == "all" || enable == "" {
+	if disable == all || enable == "" {
 		return defaultFeatures(false), nil
 	}
 	var items []string
 	var features Features
-	if enable != "none" {
+	if enable != none {
 		items = strings.Split(enable, ",")
 		features = defaultFeatures(false)
 	} else {
@@ -286,7 +290,7 @@ func ParseFeaturesFlags(enable string, disable string, defaultValue bool) (Featu
 			return nil, fmt.Errorf("unknown feature specified: %s", item)
 		}
 		feature := features[item]
-		feature.Enabled = (enable != "none")
+		feature.Enabled = enable != none
 		features[item] = feature
 	}
 	return features, nil