diff options
| author | Dmitry Vyukov <dvyukov@google.com> | 2020-10-26 10:51:06 +0100 |
|---|---|---|
| committer | Dmitry Vyukov <dvyukov@google.com> | 2020-10-26 15:44:28 +0100 |
| commit | e6e35dba937599d098fc034eff2686e5ddc409e9 (patch) | |
| tree | 802be708d0bc84dee01b9285639690a53f1f6f94 /pkg/csource/csource_test.go | |
| parent | d46bc75207fea1d7671c1277dd660cf1a4d7847b (diff) | |
sys/targets: add OS/Arch name consts
We use strings to identify OS/Arch.
These strings are duplicated throughout the code base massively.
golangci-lint points to possiblity of typos and duplication.
We already had to define these names in pkg/csource
and disable checking for prog package. A future change triggers
such warnings in another package.
Add OS/Arch name consts to sys/targets so that they can be used
to refer to OS/Arch. Use the consts everywhere.
Diffstat (limited to 'pkg/csource/csource_test.go')
| -rw-r--r-- | pkg/csource/csource_test.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/pkg/csource/csource_test.go b/pkg/csource/csource_test.go index 3eec99792..f6d04b35c 100644 --- a/pkg/csource/csource_test.go +++ b/pkg/csource/csource_test.go @@ -136,7 +136,7 @@ func TestSysTests(t *testing.T) { } t.Run(target.OS+"/"+target.Arch, func(t *testing.T) { t.Parallel() - dir := filepath.Join("..", "..", "sys", target.OS, "test") + dir := filepath.Join("..", "..", "sys", target.OS, targets.TestOS) if !osutil.IsExist(dir) { return } @@ -173,7 +173,7 @@ func TestSysTests(t *testing.T) { func TestExecutorMacros(t *testing.T) { // Ensure that executor does not mis-spell any of the SYZ_* macros. - target, _ := prog.GetTarget("test", "64") + target, _ := prog.GetTarget(targets.TestOS, targets.TestArch64) p := target.Generate(rand.NewSource(0), 1, target.DefaultChoiceTable()) expected := commonDefines(p, Options{}) expected["SYZ_EXECUTOR"] = true |