diff options
| author | Taras Madan <tarasmadan@google.com> | 2025-02-28 13:57:50 +0100 |
|---|---|---|
| committer | Taras Madan <tarasmadan@google.com> | 2025-03-07 10:23:01 +0000 |
| commit | 7e3bd60dd6c8f783f5a418c64aa75f6818236dc4 (patch) | |
| tree | 24dce56dc037521e340e73f45ba41c8b6c264af2 /pkg/cover | |
| parent | 831e3629115be4f5e68e6e0df3a5b07eed26daa4 (diff) | |
pkg/symbolizer: introduce Symbolizer interface
To simplify interface Read*Symbols were moved out from symbolizer.Symbolizer.
Diffstat (limited to 'pkg/cover')
| -rw-r--r-- | pkg/cover/backend/dwarf.go | 4 | ||||
| -rw-r--r-- | pkg/cover/report_test.go | 3 |
2 files changed, 3 insertions, 4 deletions
diff --git a/pkg/cover/backend/dwarf.go b/pkg/cover/backend/dwarf.go index a6045b91e..7be2832d3 100644 --- a/pkg/cover/backend/dwarf.go +++ b/pkg/cover/backend/dwarf.go @@ -419,7 +419,7 @@ func symbolizeModule(target *targets.Target, interner *symbolizer.Interner, objD pcchan := make(chan []uint64, procs) for p := 0; p < procs; p++ { go func() { - symb := symbolizer.NewSymbolizer(target) + symb := symbolizer.Make(target) defer symb.Close() var res symbolizerResult for pcs := range pcchan { @@ -430,7 +430,7 @@ func symbolizeModule(target *targets.Target, interner *symbolizer.Interner, objD pcs[i] = pc - mod.Addr } } - frames, err := symb.SymbolizeArray(mod.Path, pcs) + frames, err := symb.Symbolize(mod.Path, pcs...) if err != nil { res.err = fmt.Errorf("failed to symbolize: %w", err) } diff --git a/pkg/cover/report_test.go b/pkg/cover/report_test.go index 77b1aaffc..8f27590e9 100644 --- a/pkg/cover/report_test.go +++ b/pkg/cover/report_test.go @@ -357,8 +357,7 @@ func generateReport(t *testing.T, target *targets.Target, test *Test) (*reports, } else if target.OS == runtime.GOOS && (target.Arch == runtime.GOARCH || target.VMArch == runtime.GOARCH) { t.Fatal(err) } else { - symb := symbolizer.NewSymbolizer(target) - text, err := symb.ReadTextSymbols(bin) + text, err := symbolizer.ReadTextSymbols(bin) if err != nil { t.Fatal(err) } |