diff options
| author | Dmitry Vyukov <dvyukov@google.com> | 2021-03-16 11:54:37 +0100 |
|---|---|---|
| committer | Dmitry Vyukov <dvyukov@google.com> | 2021-03-18 09:17:51 +0100 |
| commit | 2649114619f2c83ca9beb0e122445b1820cc1646 (patch) | |
| tree | eacfa2e6e79df04b19fc386f7669b27178a9208a /pkg/cover/report.go | |
| parent | a32dae5902fec8911336f5fc7d1e8b2292589fde (diff) | |
pkg/mgrconfig: move Subsystem from pkg/cover
mgrconfig used to be "leaf" package that can be imported by anything.
Recently it started importing pkg/cover for Subsystem definition.
It leads to the following import cycle if I try to import
pkg/host from pkg/cover:
package github.com/google/syzkaller/pkg/bisect
imports github.com/google/syzkaller/pkg/build
imports github.com/google/syzkaller/pkg/mgrconfig
imports github.com/google/syzkaller/pkg/cover
imports github.com/google/syzkaller/pkg/host
imports github.com/google/syzkaller/pkg/csource
imports github.com/google/syzkaller/pkg/mgrconfig:
import cycle not allowed
Move Subsystem into pkg/mgrconfig itself.
Diffstat (limited to 'pkg/cover/report.go')
| -rw-r--r-- | pkg/cover/report.go | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/pkg/cover/report.go b/pkg/cover/report.go index 94540b6c8..b838d5f5f 100644 --- a/pkg/cover/report.go +++ b/pkg/cover/report.go @@ -8,6 +8,7 @@ import ( "sort" "github.com/google/syzkaller/pkg/cover/backend" + "github.com/google/syzkaller/pkg/mgrconfig" "github.com/google/syzkaller/sys/targets" ) @@ -16,7 +17,7 @@ type ReportGenerator struct { srcDir string objDir string buildDir string - subsystem []Subsystem + subsystem []mgrconfig.Subsystem *backend.Impl } @@ -27,13 +28,13 @@ type Prog struct { var RestorePC = backend.RestorePC -func MakeReportGenerator(target *targets.Target, vm, objDir, srcDir, buildDir string, - subsystem []Subsystem, moduleObj []string, modules map[string]backend.KernelModule) (*ReportGenerator, error) { +func MakeReportGenerator(target *targets.Target, vm, objDir, srcDir, buildDir string, subsystem []mgrconfig.Subsystem, + moduleObj []string, modules map[string]backend.KernelModule) (*ReportGenerator, error) { impl, err := backend.Make(target, vm, objDir, srcDir, buildDir, moduleObj, modules) if err != nil { return nil, err } - subsystem = append(subsystem, Subsystem{ + subsystem = append(subsystem, mgrconfig.Subsystem{ Name: "all", Paths: []string{""}, }) |
