diff options
| author | Aleksandr Nogikh <nogikh@google.com> | 2023-10-05 17:40:16 +0200 |
|---|---|---|
| committer | Aleksandr Nogikh <nogikh@google.com> | 2023-10-06 11:42:31 +0000 |
| commit | 160f76ea821e29048389ecb03e8961c4e9cdf519 (patch) | |
| tree | fd38f69adefd6210f56ea30340954d8a4093d248 /pkg/compiler/check.go | |
| parent | 7e4eb997711a9389137dc3bcaeb000ef1fd669bf (diff) | |
pkg/compiler: support (in) for union fields
We had a problem -- using inout ANYUNION leads to syzkaller generating
copyout instructions for fmt[X, resource] types.
Add a validation rule to detect this during tests.
Fix this by supporting (in) for union fields. Previously, all union
field direction attributes were banned as they were making things more
complicated.
The (in) attribute is definitely safe and allows for more flexibility.
Diffstat (limited to 'pkg/compiler/check.go')
| -rw-r--r-- | pkg/compiler/check.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/pkg/compiler/check.go b/pkg/compiler/check.go index 4b2dd1330..5f7bb7108 100644 --- a/pkg/compiler/check.go +++ b/pkg/compiler/check.go @@ -185,7 +185,7 @@ func (comp *compiler) checkStructFields(n *ast.Struct, typ, name string) { hasDirections, hasOutOverlay := false, false for fieldIdx, f := range n.Fields { if n.IsUnion { - comp.parseAttrs(nil, f, f.Attrs) + comp.parseAttrs(unionFieldAttrs, f, f.Attrs) continue } attrs := comp.parseAttrs(structFieldAttrs, f, f.Attrs) |