diff options
| author | Dmitry Vyukov <dvyukov@google.com> | 2019-11-27 14:05:14 +0100 |
|---|---|---|
| committer | Dmitry Vyukov <dvyukov@google.com> | 2019-11-27 14:05:14 +0100 |
| commit | 6f7be11fa1dfb7538af54ffafd1cc644d3975a1d (patch) | |
| tree | 2c5e659127245a15b559ecc1dcda66cacbfbac6c /pkg/bisect/bisect.go | |
| parent | 9f5fd6fe1a3835945ce119f2b5d3633d3b81ff61 (diff) | |
dashboard/app: don't report bisections pointing to release commits
They should have been detected by "same binary" logic.
But the problem is that we may use different compilers
for different commits and they switch exactly at release commits.
So we can build the release with a differnet compiler than the
rest of commits and then obviously it won't be "same binary".
Detect release commits separately.
Update #1271
Diffstat (limited to 'pkg/bisect/bisect.go')
| -rw-r--r-- | pkg/bisect/bisect.go | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/pkg/bisect/bisect.go b/pkg/bisect/bisect.go index 4fbeeec4f..1f3d8ea61 100644 --- a/pkg/bisect/bisect.go +++ b/pkg/bisect/bisect.go @@ -71,6 +71,7 @@ const NumTests = 10 // number of tests we do per commit // - Commit is nil // - NoopChange is set if the commit did not cause any change in the kernel binary // (bisection result it most likely wrong) +// - Bisected to a release commit // - if bisection is inconclusive, range of potential cause/fix commits in Commits // - report is nil in such case // - Commit is nil @@ -83,6 +84,7 @@ type Result struct { Report *report.Report Commit *vcs.Commit NoopChange bool + IsRelease bool } // Run does the bisection and returns either the Result, @@ -221,6 +223,11 @@ func (env *env) bisect() (*Result, error) { } if len(commits) == 1 { com := commits[0] + isRelease, err := env.bisecter.IsRelease(com.Hash) + if err != nil { + env.log("failed to detect release: %v", err) + } + res.IsRelease = isRelease if testRes := results[com.Hash]; testRes != nil { res.Report = testRes.rep if testRes.kernelSign != "" && len(com.Parents) == 1 { |