diff options
| author | Dmitry Vyukov <dvyukov@google.com> | 2024-04-16 16:35:18 +0200 |
|---|---|---|
| committer | Dmitry Vyukov <dvyukov@google.com> | 2024-04-17 13:48:18 +0000 |
| commit | acc528cbf40c42eb112d2ce66c5f778bd4a397fb (patch) | |
| tree | 1db39cbb9517df790fdf189d3bd1f59e4b7a8b0c /pkg/asset | |
| parent | 18f6e127bf6e515fc3eee0936bde2415e676e160 (diff) | |
tools/syz-linter: check t.Logf/Errorf/Fatalf messages
Fix checking of Logf, it has string in 0-th arg.
Add checking of t.Errorf/Fatalf.
Diffstat (limited to 'pkg/asset')
| -rw-r--r-- | pkg/asset/storage_test.go | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/pkg/asset/storage_test.go b/pkg/asset/storage_test.go index dcafdacf4..7500e9db3 100644 --- a/pkg/asset/storage_test.go +++ b/pkg/asset/storage_test.go @@ -184,14 +184,14 @@ func TestUploadBuildAsset(t *testing.T) { be.objectRemove = func(string) error { return fmt.Errorf("not now") } err = storage.DeprecateAssets() if err == nil { - t.Fatalf("DeprecateAssets() should have failed") + t.Fatalf("DeprecateAssets should have failed") } // Let the deletion be successful. be.objectRemove = nil err = storage.DeprecateAssets() if err != nil { - t.Fatalf("DeprecateAssets() was expected to be successful, got %s", err) + t.Fatalf("DeprecateAssets was expected to be successful, got %s", err) } path, err := be.getPath(allUrls[2]) if err != nil { @@ -199,14 +199,14 @@ func TestUploadBuildAsset(t *testing.T) { } err = be.hasOnly([]string{path}) if err != nil { - t.Fatalf("after first DeprecateAssets(): %s", err) + t.Fatalf("after first DeprecateAssets: %s", err) } // Delete the rest. dashMock.downloadURLs = map[string]bool{} err = storage.DeprecateAssets() if err != nil || len(be.objects) != 0 { - t.Fatalf("second DeprecateAssets() failed: %s, len %d", + t.Fatalf("second DeprecateAssets failed: %s, len %d", err, len(be.objects)) } } @@ -365,7 +365,7 @@ func TestTwoBucketDeprecation(t *testing.T) { url: true, } dummy.objectRemove = func(url string) error { - t.Fatalf("Unexpected removal") + t.Fatalf("unexpected removal") return nil } err := storage.DeprecateAssets() @@ -389,7 +389,7 @@ func TestInvalidAssetURLs(t *testing.T) { url: true, } dummy.objectRemove = func(url string) error { - t.Fatalf("Unexpected removal") + t.Fatalf("unexpected removal") return nil } err := storage.DeprecateAssets() |