diff options
| author | Dmitry Vyukov <dvyukov@google.com> | 2021-02-21 12:32:11 +0100 |
|---|---|---|
| committer | Dmitry Vyukov <dvyukov@google.com> | 2021-02-21 16:43:26 +0100 |
| commit | a659b3f1dc889d5ab5ead017b877765b3d042379 (patch) | |
| tree | 8df03976c96285623e94f39e7a44773170b0a9d8 /executor/style_test.go | |
| parent | e894953c0c45c8a6d676292a81da90a615133b1c (diff) | |
pkg/report: detect executor failures
Currently all executor fail errors go into "lost connection" bucket.
This is not very useful. First, there are different executor failures.
Second, it's not possible to understand what failures happen how frequently.
Third, there are not authentic lost connection.
Create separate SYZFAIL: bugs for them.
Update #573
Update #502
Update #318
Diffstat (limited to 'executor/style_test.go')
| -rw-r--r-- | executor/style_test.go | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/executor/style_test.go b/executor/style_test.go index 3b0ee8ce7..9c83f2536 100644 --- a/executor/style_test.go +++ b/executor/style_test.go @@ -111,12 +111,20 @@ if (foo) }, }, { - pattern: `\s*(fail|exitf)\(".*\\n`, + pattern: `(fail|exitf)\(".*\\n`, message: "Don't use \\n in fail/exitf messages", tests: []string{ `fail("some message with new line\n");`, }, }, + { + pattern: `fail(msg)?\("[^"]*%`, + message: "DON'T", + tests: []string{ + `fail("format %s string")`, + `failmsg("format %s string", "format")`, + }, + }, } for _, check := range checks { re := regexp.MustCompile(check.pattern) |