diff options
| author | Dmitry Vyukov <dvyukov@google.com> | 2024-06-03 12:36:29 +0200 |
|---|---|---|
| committer | Dmitry Vyukov <dvyukov@google.com> | 2024-06-03 13:22:24 +0000 |
| commit | 04106220bf532bd22d1c36245416d060836aa0a7 (patch) | |
| tree | 1a1fb8f2dfce786264c09c122373d05927b47f9c /executor/executor_linux.h | |
| parent | 845e65a5b9735429f1336e165f762cba9ce13f71 (diff) | |
executor: fix gvisor signal
Fix 2 bugs:
1. We remove low 12 bits of every PC on amd64 b/c use_cover_edges return true.
This results in extremly low signal (gvisor PC are dense integers).
2. We hash prev/next PC on arm64 which does not make sense
since gvisor coverage is not a trace. This results in falsely large signal.
Diffstat (limited to 'executor/executor_linux.h')
| -rw-r--r-- | executor/executor_linux.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/executor/executor_linux.h b/executor/executor_linux.h index 1bae0e460..8b37ea598 100644 --- a/executor/executor_linux.h +++ b/executor/executor_linux.h @@ -182,9 +182,11 @@ static bool use_cover_edges(uint32 pc) static bool use_cover_edges(uint64 pc) { -#if defined(__i386__) || defined(__x86_64__) +#if GOARCH_amd64 || GOARCH_arm64 if (is_gvisor) return false; // gvisor coverage is not a trace, so producing edges won't work +#endif +#if GOARCH_386 || GOARCH_amd64 // Text/modules range for x86_64. if (pc < 0xffffffff80000000ull || pc >= 0xffffffffff000000ull) { debug("got bad pc: 0x%llx\n", pc); |