sys/linux, sys/freebsd: apply more ignore_return attributes

1. Apply ignore_return to semctl$GETVAL which produces random errno
values on linux and freebsd.

2. Apply ignore_return to prctl and remove the custom code in executor.

3. Remove the custom errno ignoring code in fuchsia executor.
The calls are already marked as ignore_return, so this is just a leftover.

4. Only reset errno for ignore_return.
The syscall can still return a resource (maybe).
We only need to reset errno for fallback coverage.

1 files changed, 0 insertions, 9 deletions

diff --git a/executor/executor_fuchsia.h b/executor/executor_fuchsia.h
index 84ebac44d..88a1ccff5 100644
--- a/executor/executor_fuchsia.h
+++ b/executor/executor_fuchsia.h
@@ -22,15 +22,6 @@ static intptr_t execute_syscall(const call_t* c, intptr_t a[kMaxArgs])
 {
 	intptr_t res = c->call(a[0], a[1], a[2], a[3], a[4], a[5], a[6], a[7], a[8]);
 	if (strncmp(c->name, "zx_", 3) == 0) {
-		// Convert zircon error convention to the libc convention that executor expects.
-		// The following calls return arbitrary integers instead of error codes.
-		if (res == ZX_OK ||
-		    !strcmp(c->name, "zx_debuglog_read") ||
-		    !strcmp(c->name, "zx_clock_get") ||
-		    !strcmp(c->name, "zx_clock_get_monotonic") ||
-		    !strcmp(c->name, "zx_deadline_after") ||
-		    !strcmp(c->name, "zx_ticks_get"))
-			return 0;
 		errno = (-res) & 0x7f;
 		return -1;
 	}