diff options
| author | Dmitry Vyukov <dvyukov@google.com> | 2021-03-17 12:28:27 +0100 |
|---|---|---|
| committer | Dmitry Vyukov <dvyukov@google.com> | 2021-03-18 09:17:51 +0100 |
| commit | 4ca2935d663453b098b895ae56a309f3efb6a4b9 (patch) | |
| tree | 10691719c1c7847815a3c1278d6c8f5ee75766de /executor/executor.cc | |
| parent | 2732397851f598a678a441cb641f630b94e18761 (diff) | |
pkg/cover: refactor extraction of coverage points
1. Add module.Addr right in objdump, there is not point in the separate loop.
It only adds unnecessary lines of code.
2. Eliminate excessive module.Name == "" checks.
We already check module.Name == "" in makeELF, there is no point
in the separate check in readCoverPoints. It also does 2 completely
different things, it's a bad way to structure code. Split it into
readCoverPoints and readModuleCoverPoints.
3. Refactor readModuleCoverPoints.
It can be much more compact, one reasonably short function.
Also avoid reading ELF symbols for every relocation,
it's completely unnecessary. We already read symbols in readSymbols,
so we don't need to re-read them again at all.
Diffstat (limited to 'executor/executor.cc')
0 files changed, 0 insertions, 0 deletions