diff options
| author | Dmitry Vyukov <dvyukov@google.com> | 2020-02-18 08:41:46 +0100 |
|---|---|---|
| committer | Dmitry Vyukov <dvyukov@google.com> | 2020-02-18 10:31:02 +0100 |
| commit | 39cd0f85a1ac60b88c793bd8f4a981227614da88 (patch) | |
| tree | 1b2085d375199b8ce1251a41218129ceea1209db /executor/common_linux.h | |
| parent | b97f1e694a1c096eac2f48c6e3ca47e8a3c4693c (diff) | |
executor: disable IFF_NAPI_FRAGS
Update #1594
Diffstat (limited to 'executor/common_linux.h')
| -rw-r--r-- | executor/common_linux.h | 13 |
1 files changed, 12 insertions, 1 deletions
diff --git a/executor/common_linux.h b/executor/common_linux.h index 94673266b..27f934799 100644 --- a/executor/common_linux.h +++ b/executor/common_linux.h @@ -502,19 +502,30 @@ static void initialize_tun(void) struct ifreq ifr; memset(&ifr, 0, sizeof(ifr)); strncpy(ifr.ifr_name, TUN_IFACE, IFNAMSIZ); - ifr.ifr_flags = IFF_TAP | IFF_NO_PI | IFF_NAPI | IFF_NAPI_FRAGS; + ifr.ifr_flags = IFF_TAP | IFF_NO_PI; + // Note: SYZ_ENABLE_NAPI_FRAGS is never enabled. This is code is only for reference + // in case we figure out how IFF_NAPI_FRAGS works. With IFF_NAPI_FRAGS packets + // don't reach destinations and bail out in udp_gro_receive (see #1594). + // Also IFF_NAPI_FRAGS does not work with sandbox_namespace (see comment there). +#if ENABLE_NAPI_FRAGS + ifr.ifr_flags |= IFF_NAPI | IFF_NAPI_FRAGS; +#endif if (ioctl(tunfd, TUNSETIFF, (void*)&ifr) < 0) { +#if ENABLE_NAPI_FRAGS // IFF_NAPI_FRAGS requires root, so try without it. ifr.ifr_flags = IFF_TAP | IFF_NO_PI; if (ioctl(tunfd, TUNSETIFF, (void*)&ifr) < 0) +#endif fail("tun: ioctl(TUNSETIFF) failed"); } +#if ENABLE_NAPI_FRAGS // If IFF_NAPI_FRAGS is not supported it will be silently dropped, // so query the effective flags. if (ioctl(tunfd, TUNGETIFF, (void*)&ifr) < 0) fail("tun: ioctl(TUNGETIFF) failed"); tun_frags_enabled = (ifr.ifr_flags & IFF_NAPI_FRAGS) != 0; debug("tun_frags_enabled=%d\n", tun_frags_enabled); +#endif // Disable IPv6 DAD, otherwise the address remains unusable until DAD completes. // Don't panic because this is an optional config. |